chore(firefox): rewrite error message for $HOME directory ownership mismatch #28921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
rewrite-firefox-startup-error-home-folder-mismatch
branch
3 times, most recently
from
cd92836
to
123f2fb
Compare
mxschmitt
force-pushed
the
rewrite-firefox-startup-error-home-folder-mismatch
branch
from
123f2fb
to
cd05efe
Compare
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Jan 9, 2024
| @@ -40,6 +40,9 @@ export class Firefox extends BrowserType { | |||
| _doRewriteStartupLog(error: ProtocolError): ProtocolError { | |||
| if (!error.logs) | |||
| return error; | |||
| // https://github.com/microsoft/playwright/issues/6500 | |||
There was a problem hiding this comment.
Let's check that we are running in Docker too?
There was a problem hiding this comment.
This issue could also affect non-Docker.
Test results for "tests 1"3 flaky14890 passed, 314 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28896
Looks like this:
