Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ct): fix the non-react cli entry points #29748

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

pavelfeldman
Copy link
Member

Fixes #29746

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add an installation test?

@pavelfeldman pavelfeldman merged commit 532d8e5 into microsoft:main Feb 29, 2024
29 checks passed
Copy link
Contributor

Test results for "tests 1"

13 flaky ⚠️ [chromium] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/interception.spec.ts:104:3 › should intercept network activity from worker
⚠️ [chromium] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke
⚠️ [chromium] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:22:5 › should update trace live
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots
⚠️ [webkit] › library/browsercontext-basic.spec.ts:79:3 › should isolate localStorage and cookies @smoke

26630 passed, 614 skipped
✔️✔️✔️

Merge workflow run.

@jan-molak
Copy link
Contributor

Shall we add an installation test?

@dgozman - In Serenity/JS, we have a couple of integration test modules that exercise Serenity/JS with other supported frameworks, such as playwright-test-ct. That's how I found #29746 when Renovate proposed to upgrade our dependency on Playwright to 1.42.0

Maybe a similar integration test could be useful in the Playwright repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression]: Playwright CT CLI scripts fail due to broken initializePlugin import
3 participants