api: export all browsers from every package #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
Jul 24, 2020
aslushnikov
approved these changes
Jul 24, 2020
aslushnikov
reviewed
Jul 24, 2020
| @@ -100,7 +100,7 @@ async function checkRangeAvailability(fromRevision, toRevision, stopWhenAllAvail | |||
| * @return {boolean} | |||
| */ | |||
| async function checkAndDrawRevisionAvailability(table, name, revision) { | |||
| const promises = fetcherOptions.map(platform => browserFetcher.canDownload(name, revision, platform)); | |||
| const promises = fetcherOptions.map(platform => browserFetcher.canDownload({ name, revision, download: true }, platform)); | |||
There was a problem hiding this comment.
the download: true argument to the canDownload method does look uncanny to me.
How do you feel splitting download bit from BrowserDescriptor into a separate field? It'll solve all the weird typing issues since absolute majority of clients of BrowserDescriptor object (e.g. revisionURL() and canDownload() functions) don't need download bit.
For example, browsers.json could look like this:
{
"comment": "Do not edit this file, use utils/roll_browser.js",
"download": ["chromium", "firefox", "webkit"],
"browsers": [
{
"name": "chromium",
"revision": "791201"
},
{
"name": "firefox",
"revision": "1140"
},
{
"name": "webkit",
"revision": "1317"
}
]
}If you like the idea but don't have time to follow-up with it, I'll send you a PR as this lands.
This makes it easier to reason about our packages. The only difference is what each package downloads. When the browser is not downloaded, it will fail to launch. Each browser gets a 'download' attribute in the browser.json file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to reason about our packages.
The only difference is what each package downloads.
When the browser is not downloaded, it will fail to launch.
Each browser gets a 'download' attribute in the browser.json file.