Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ct): export package.json #31504

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

mxschmitt
Copy link
Member

As per https://github.com/microsoft/playwright-vscode/blob/fc6d85877b9d5c1b40313febb336d240a7d201d5/src/playwrightFinder.ts#L33 we should export package.json for CT. This was not noticed before, because NPM does install the dependencies, aka. playwright in the root of the node_modules directory while PNPM does it nested / deep.

Fixes #31491

Investigation credits go to #31491.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Test results for "tests 1"

8 flaky ⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/capabilities.spec.ts:137:3 › should not crash on showDirectoryPicker
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots
⚠️ [webkit-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:49:3 › get should work on request fixture

28405 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit b349a73 into microsoft:main Jul 1, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: @playwright/experimental-ct-react does not export package.json, which breaks VS Code extension
2 participants