chore: bump TypeScript to v5.5 #31532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to make sure that our exposed @playwright/test types work with the latest TypeScript version and didn't introduce unwanted regressions. Also this release offers a lot of great enhancements which should make our developer experience better: https://devblogs.microsoft.com/typescript/announcing-typescript-5-5/
mxschmitt
commented
Jul 3, 2024
mxschmitt
commented
Jul 3, 2024
| @@ -282,16 +282,16 @@ export async function convertInputFiles(files: string | FilePayload | string[] | | |||
| if (!items.every(item => typeof item === 'string')) | |||
| throw new Error('File paths cannot be mixed with buffers'); | |||
|
|
|||
| const [localPaths, localDirectory] = await resolvePathsAndDirectoryForInputFiles(items as string[]); | |||
| const [localPaths, localDirectory] = await resolvePathsAndDirectoryForInputFiles(items); | |||
There was a problem hiding this comment.
This is one of the highlights in this TypeScript v5.5 release. That filter will have the filter'ed type.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Jul 3, 2024
Test results for "tests 1"7 flaky28423 passed, 654 skipped Merge workflow run. |
dgozman
added a commit
that referenced
this pull request
Aug 8, 2024
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Aug 8, 2024
… support TS 5.5 Regressed in microsoft#31532. The TS5.5 changes broke chaining of `extend`s where the first `extend` did not specify any type arguments. Fixes microsoft#32056.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make sure that our exposed @playwright/test types work with the latest TypeScript version and didn't introduce unwanted regressions. Also this release offers a lot of great enhancements which should make our developer experience better: https://devblogs.microsoft.com/typescript/announcing-typescript-5-5/