cherry-pick(#31768): fix(trace viewer): library-only trace should not merge actions #31780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actions when no library trace is present Recent logic that matches either by `stepId` or by `apiName`+`wallTime` did not account for "no library trace" scenario.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Jul 20, 2024
…hould not merge actions Without `wallTime`, actions are matched by `actionName:undefined` and all actions with the same are merged. Fixes microsoft#31764.
Test results for "tests 1"2 flaky28749 passed, 692 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks two trace viewer fixes:
cherry-pick(#31768): fix(trace viewer): library-only trace should not merge actions
cherry-pick(#31564): fix(trace): do not corrupt test runner actions when no library trace is present
Reference: microsoft/playwright-java#1617