Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): Point to hosted docs #3208

Merged
merged 3 commits into from
Jul 31, 2020
Merged

Conversation

anishkny
Copy link
Contributor

Instead of markdown docs/README.md

Instead of markdown `docs/README.md`
Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! There are ~10 more links in README.md, and we should update either all of them or none.

@ghost
Copy link

ghost commented Jul 30, 2020

CLA assistant check
All CLA requirements met.

@anishkny
Copy link
Contributor Author

@dgozman sound fair. I pretty much replaced, e.g.:

- docs/FOO.md[#BAR]
+ https://playwright.dev/#?path=docs/FOO.md[&q=BAR]

LMK if this works!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dgozman dgozman merged commit 70b92e1 into microsoft:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants