devops(firefox): fixate rust and cbindgen version #3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox buildchain does not fixate `rust` and `cbindgen` versions, so we want to fixate them on our end. A table with matching rust version for every firefox version can be found at [Rust Update Policy for Firefox](https://wiki.mozilla.org/Rust_Update_Policy_for_Firefox). Additionally, there are checks in `mozbuild` for the minimum rust version and minimum `cbindgen` version.
yury-s
approved these changes
Jul 30, 2020
| @@ -41,6 +44,12 @@ echo "mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/${OBJ_FOLDER}" >> .mozconfig | |||
| if [[ $1 == "--juggler" ]]; then | |||
| ./mach build faster | |||
| else | |||
| # We manage Rust version ourselves. | |||
There was a problem hiding this comment.
Should we cache the result to reduce impact on the build time?
There was a problem hiding this comment.
It should be quite instant, at least on Linux and Mac.
I'm yet to check no windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox buildchain does not fixate
rustandcbindgenversions,so we want to fixate them on our end.
A table with matching rust version for every firefox version can
be found at Rust Update Policy for Firefox.
Additionally, there are checks in
mozbuildfor the minimumrust version and minimum
cbindgenversion.