-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devops: unite channel tests into single GHA matrix workflows #32876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Sep 30, 2024
strategy: | ||
fail-fast: false | ||
matrix: | ||
channel: [chrome, chrome-beta, msedge, msedge-beta, msedge-dev] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively we create the matrix ourselves using:
- channel: chrome
runs-on: ubuntu-20.04
- channel: chrome
runs-on: macos-latest
- channel: chrome
runs-on: windows-latest
- channel: chrome-beta
runs-on: ubuntu-20.04
- channel: chrome-beta
runs-on: macos-latest
- channel: chrome-beta
runs-on: windows-latest
- channel: msedge
runs-on: ubuntu-20.04
- channel: msedge
runs-on: macos-latest
- channel: msedge
runs-on: windows-latest
- channe: msedge-beta
runs-on: ubuntu-20.04
- channe: msedge-beta
runs-on: macos-latest
- channe: msedge-beta
runs-on: windows-latest
- channel: msedge-dev
runs-on: ubuntu-20.04
- channel: msedge-dev
runs-on: macos-latest
- channel: msedge-dev
runs-on: windows-latest
not sure if we need the fine grade control, probably not and this is fine?
dgozman
approved these changes
Sep 30, 2024
Co-authored-by: Dmitry Gozman <dgozman@gmail.com> Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com> Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com> Signed-off-by: Max Schmitt <max@schmitt.mx>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests others"1 flaky20720 passed, 538 skipped Merge workflow run. |
Test results for "tests 1"2 flaky36408 passed, 758 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.