chore: unflake 'should record' #32880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
unflake-should-record-test
branch
from
1402313
to
d5f57fa
Compare
Test results for "tests 1"3 flaky36412 passed, 758 skipped Merge workflow run. |
pavelfeldman
approved these changes
Sep 30, 2024
mxschmitt
added a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its caused by a change made here. With that we call
this._fireChange()twice for the same set of actions. This ends up in twosourceChangedevents in the debug controller. We should not fire the same 'change' event if its not enabled.Why was it racy? Because its fired in a microtask, depending on the load, it might or might not happen - turns out it only happened on busy systems.