fix(emulate media): document "no-preference" as deprecated #32881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
commented
Sep 30, 2024
docs/src/api/params.md
Outdated
| @@ -639,14 +639,14 @@ If no origin is specified, the username and password are sent to any servers upo | |||
| * langs: js, java | |||
| - `colorScheme` <null|[ColorScheme]<"light"|"dark"|"no-preference">> | |||
|
|
|||
| Emulates `'prefers-colors-scheme'` media feature, supported values are `'light'`, `'dark'`, `'no-preference'`. See | |||
| Emulates `'prefers-colors-scheme'` media feature, supported values are `'light'` and `'dark'`. See | |||
There was a problem hiding this comment.
to keep it short, I didn't include the "no-preference is deprecated" info in this one. Interested folks can figure that out by following the "see Page.emulateMedia" link.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Oct 4, 2024
Co-authored-by: Dmitry Gozman <dgozman@gmail.com> Signed-off-by: Simon Knott <info@simonknott.de>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"35761 passed, 680 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32862.
prefers-color-scheme: no-preferencewas removed from browsers. This PR marks it as deprecated in our docs and removes all mentions.