feat(screencast): add private recording APIs and basic test #3296
Conversation
| @@ -58,6 +58,8 @@ export interface PageDelegate { | |||
| canScreenshotOutsideViewport(): boolean; | |||
| resetViewport(): Promise<void>; // Only called if canScreenshotOutsideViewport() returns false. | |||
| setBackgroundColor(color?: { r: number; g: number; b: number; a: number; }): Promise<void>; | |||
| startVideoRecording(options: types.VideoRecordingOptions): Promise<void>; | |||
There was a problem hiding this comment.
Let's move this to the browser context to cover popups, wdyt?
There was a problem hiding this comment.
That's the ultimate plan. This requires generating file names, events that video started etc. For now I'd like to have basic functionality to provide some test coverage. Context level API can be added on top of it. Do you think we won't need page level start/stop functionality?
There was a problem hiding this comment.
As long as it is on delegate only - lgtm!
|
I'd love to have a |
yury-s
force-pushed
the
screencast-private-and-test
branch
from
f77880f
to
d40c3d5
Compare
I actually had an argument against namespaces - they made rpc / other langs a bit harder to implement. So I would love to learn why you prefer it to make sure we make a balanced call |
yury-s
force-pushed
the
screencast-private-and-test
branch
2 times, most recently
from
135b74d
to
3bb284d
Compare
yury-s
force-pushed
the
screencast-private-and-test
branch
from
845456e
to
5b77b33
Compare
#1158