-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "fix(har timing): record connect
timing for proxied connections"
#32989
Conversation
This comment has been minimized.
This comment has been minimized.
Test results for "tests others"1 flaky20521 passed, 491 skipped Merge workflow run. |
Test results for "tests 2"5 failed 47 flaky242129 passed, 9542 skipped Merge workflow run. |
There might be a trivial way of fixing the tests tho. I'd try keep digging / we can try to reland it again alter on. If you need help we can also take a look together. |
Test results for "tests 1"35849 passed, 619 skipped Merge workflow run. |
…ions" (microsoft#32989) This reverts commit 1b589c4.
…ns" (#32855) (#33003) This reapplies what we reverted in #32989. Max and me debugged this, and found that the test failures come from SOCKS proxy now preferring IPv6 over IPv4. We've updated the tests and made sure that this doesn't mask any breaking change. I'm enabling CQ1 to make sure we don't oversee any other CI failures.
Reverts #32855. This broke two tests on main, and we don't yet know how to fix it other than downgrading.