Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(har timing): record connect timing for proxied connections" #32989

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Oct 7, 2024

Reverts #32855. This broke two tests on main, and we don't yet know how to fix it other than downgrading.

This comment has been minimized.

@Skn0tt Skn0tt added the CQ1 label Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Test results for "tests others"

1 flaky ⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:59:5 › should run component tests after editing test

20521 passed, 491 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Test results for "tests 2"

5 failed
❌ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
❌ [chromium-page] › page/interception.spec.ts:124:3 › should intercept worker requests when enabled after worker creation
❌ [chromium-page] › page/interception.spec.ts:124:3 › should intercept worker requests when enabled after worker creation
❌ [chromium-page] › page/interception.spec.ts:124:3 › should intercept worker requests when enabled after worker creation
❌ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames fit

47 flaky ⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4)
⚠️ [chromium-library] › library/inspector/pause.spec.ts:143:5 › pause › should step with keyboard shortcut
⚠️ [chromium-library] › library/inspector/pause.spec.ts:425:5 › pause › should not prevent key events
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:556:7 › cli codegen › should generate getByLabel without regex
⚠️ [chromium-page] › page/page-mouse.spec.ts:174:3 › should select the text with mouse
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click
⚠️ [chromium-page] › page/page-drag.spec.ts:56:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium-page] › page/page-mouse.spec.ts:244:3 › should tween mouse movement
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:421:5 › launchServer › should reject waitForEvent before browser.onDisconnect fires
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1001:1 › should serve overridden request
⚠️ [firefox-library] › library/capabilities.spec.ts:254:3 › requestFullscreen
⚠️ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts
⚠️ [firefox-library] › library/browsercontext-proxy.spec.ts:366:3 › should use socks proxy in second page
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:836:7 › run-server › socks proxy › should proxy local.playwright requests
⚠️ [firefox-library] › library/capabilities.spec.ts:174:3 › should set CloseEvent.wasClean to false when the server terminates a WebSocket connection
⚠️ [firefox-library] › library/client-certificates.spec.ts:667:3 › browser › should have ignoreHTTPSErrors=false by default
⚠️ [firefox-library] › library/trace-viewer.spec.ts:374:1 › should popup snapshot
⚠️ [firefox-library] › library/tracing.spec.ts:484:5 › should work with multiple chunks
⚠️ [firefox-page] › page/page-click.spec.ts:105:3 › should click the button after navigation
⚠️ [firefox-library] › library/browsercontext-fetch.spec.ts:149:5 › patch should support params passed as URLSearchParams
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4)
⚠️ [chromium-library] › library/video.spec.ts:797:5 › screencast › should work with video+trace
⚠️ [chromium-library] › library/browsercontext-events.spec.ts:19:5 › console event should work @smoke
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:606:5 › run-server › should save har
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select
⚠️ [webkit-page] › page/page-mouse.spec.ts:244:3 › should tween mouse movement
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should double click
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should double click
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:509:7 › cli codegen › should check
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:47:7 › cli codegen › should contain second page
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:494:7 › cli codegen › should fill tricky characters
⚠️ [webkit-library] › library/trace-viewer.spec.ts:415:1 › should capture data-url svg iframe
⚠️ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames crop
⚠️ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames scale
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data
⚠️ [webkit-page] › page/wheel.spec.ts:101:3 › should dispatch wheel events after popup was opened @smoke
⚠️ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames crop
⚠️ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames scale
⚠️ [webkit-page] › page/page-request-continue.spec.ts:184:5 › post data › should amend post data
⚠️ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames scale
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path
⚠️ [webkit-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [webkit-library] › library/inspector/cli-codegen-pytest.spec.ts:33:5 › should print the correct context options when using a device and lang

242129 passed, 9542 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt
Copy link
Member

There might be a trivial way of fixing the tests tho. I'd try keep digging / we can try to reland it again alter on. If you need help we can also take a look together.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Test results for "tests 1"

35849 passed, 619 skipped
✔️✔️✔️

Merge workflow run.

@Skn0tt Skn0tt merged commit 1b589c4 into main Oct 8, 2024
29 checks passed
@Skn0tt Skn0tt deleted the revert-32855-http-proxy-har-timing-connect branch October 8, 2024 08:13
Skn0tt added a commit to Skn0tt/playwright that referenced this pull request Oct 8, 2024
Skn0tt added a commit that referenced this pull request Oct 8, 2024
…ns" (#32855) (#33003)

This reapplies what we reverted in
#32989.

Max and me debugged this, and found that the test failures come from
SOCKS proxy now preferring IPv6 over IPv4. We've updated the tests and
made sure that this doesn't mask any breaking change.

I'm enabling CQ1 to make sure we don't oversee any other CI failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants