fix: do not stall waiting for pending navigations after beforeunload dismiss #33834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Dec 3, 2024
dgozman
force-pushed
the
fix-beforeunload-stall
branch
from
48c0388 to
eb35941
Compare
Test results for "tests 1"2 flaky37195 passed, 650 skipped Merge workflow run. |
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Dec 4, 2024
…avigations after beforeunload dismiss
dgozman
added a commit
that referenced
this pull request
Dec 4, 2024
…s after beforeunload dismiss (#33856)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We receive
frameRequestedNavigation. It is cleared by dismissing thebeforeunloaddialog, but we do not receive any event about this.Fixes #33806.