Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused non-rpc code, test options, infra, bots #3444

Merged
merged 1 commit into from
Aug 13, 2020
Merged

chore: remove unused non-rpc code, test options, infra, bots #3444

merged 1 commit into from
Aug 13, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Aug 13, 2020 •
edited
Loading

  • Removes doclint pass against non-rpc, removes expandPrefix.
  • Leaves "wire" bots that run rpc over the wire.
  • Removes CHANNEL option in tests, replaces USES_HOOKS with WIRE.
  • Removes WebSocketServer and it's usages from the implementation side.
  • Removes BrowserType.connect from the implementation side.

@dgozman dgozman changed the title [WIP] chore: remove unused non-rpc code, test options, infra, bots chore: remove unused non-rpc code, test options, infra, bots Aug 13, 2020
@dgozman dgozman marked this pull request as ready for review August 13, 2020 21:12
pavelfeldman
pavelfeldman approved these changes Aug 13, 2020
View reviewed changes
src/server/browserServer.ts Show resolved Hide resolved
@dgozman dgozman merged commit 9b52ca8 into microsoft:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgozman @pavelfeldman