chore: use HeadersArray instead of Headers object on the server side #3512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies implementation and avoids multiple conversions. Also adding some tests around lowercase and wrong types.
aslushnikov
approved these changes
Aug 18, 2020
| const headers = (this._page._state.extraHTTPHeaders || {}); | ||
| let referer = headers['referer'] || headers['Referer']; | ||
| const headers = this._page._state.extraHTTPHeaders || []; | ||
| const refererHeader = headers.find(h => h.name === 'referer' || h.name === 'Referer'); |
There was a problem hiding this comment.
I know it used to be like this before, but why not
h => h.name.toLowerCase() === 'referer'There was a problem hiding this comment.
No idea. I'll follow up 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies implementation and avoids multiple conversions.
Also adding some tests around lowercase and wrong types.