Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add waitForElementState('disabled') #3537

Merged
merged 1 commit into from
Aug 20, 2020
Merged

api: add waitForElementState('disabled') #3537

merged 1 commit into from
Aug 20, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Aug 19, 2020

Allows waiting for the element to be disabled.

References #2353.

Allows waiting for the element to be disabled.
@JoelEinbinder
Copy link
Contributor

This looks fine, but it made me read all of the _isElementDisabled code we already have. It looks very strange to me. We accept role=button, but then don't look at aria-disabled? And we look at <button>/<input>/<select> but not <textarea>. Additionally these elements could be disabled without the attribute set if they are in a <fieldset>. <option>/<optGroup> might be an edge case, but they can also be disabled.

@dgozman
Copy link
Contributor Author

dgozman commented Aug 19, 2020

This looks fine, but it made me read all of the _isElementDisabled code we already have. It looks very strange to me. We accept role=button, but then don't look at aria-disabled? And we look at <button>/<input>/<select> but not <textarea>. Additionally these elements could be disabled without the attribute set if they are in a <fieldset>. <option>/<optGroup> might be an edge case, but they can also be disabled.

Sounds like we can improve stuff by a lot! Would you like to look into that?

@dgozman dgozman merged commit 1829232 into microsoft:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants