browser(webkit): use webkit generate-bundle tool to generate the minibrowser bundles #3563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
approved these changes
Aug 21, 2020
There was a problem hiding this comment.
Awesome!
Can we also bump the webkit build number to trigger build with the new build system? (simply advancing the //browser_patches/webkit/BUILD_NUMBER and optionally updating the signature)
The automated way to bump build would be to re-export webkit patch:
$ ./browser_patches/prepare_checkout.sh wk
$ ./browser_patches/export.sh wk* This changes the archive.sh script to use the webkit generate-bundle tool to generate the MiniBrowser bundles instead of using our custom logic. * pw_run.sh is simplified because the new bundles include a wrapper script that sets the needed LD_LIBRARY_PATH environment variables. pw_run.sh now calls this wrapper script (for GTK or WPE) instead of calling the MiniBrowser binary directly when running from a bundle.
clopez
force-pushed
the
webkit-use-generate-bundle
branch
from
35fad9d
to
5c1d5a9
Compare
|
I just updated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
archive.shscript to use the webkit generate-bundle tool to generate the MiniBrowser bundles instead of using our custom logic.pw_run.shis simplified because the new bundles include a wrapper script that sets the neededLD_LIBRARY_PATHenvironment variables.pw_run.shnow calls this wrapper script (for GTK or WPE) instead of calling theMiniBrowserbinary directly when running from a bundle.To test this you need to first update webkit to the last checkout:
... and test it
//CC @aslushnikov