test: collect stdout/stderr in tests #3615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
reporter14
branch
from
9944c31
to
fdcf9cc
Compare
dgozman
approved these changes
Aug 25, 2020
| require('../../..'); | ||
|
|
||
| it('stdio', () => { | ||
| process.stdout.write('stdout text'); |
There was a problem hiding this comment.
Does this work with console logs? I'm scared about our method of overwriting process.stdout.write.
There was a problem hiding this comment.
It does, i'm adding a test.
| process.stdout.write('stdout text'); | ||
| process.stdout.write(Buffer.from('stdout buffer')); | ||
| process.stderr.write('stderr text'); | ||
| process.stderr.write(Buffer.from('stderr buffer')); |
There was a problem hiding this comment.
Suggested change
| process.stderr.write(Buffer.from('stderr buffer')); | |
| process.stderr.write(Buffer.from('stderr buffer')); | |
| console.log('console log'); | |
| console.error('console.error'); |
There was a problem hiding this comment.
Yup, added a separate test!
JoelEinbinder
approved these changes
Aug 25, 2020
pavelfeldman
force-pushed
the
reporter14
branch
2 times, most recently
from
ec2dbd5
to
ce08eab
Compare
pavelfeldman
force-pushed
the
reporter14
branch
from
ce08eab
to
841b815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.