Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump dev dependencies #3659

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Aug 27, 2020

Updated dependencies which is always good and added the chromium output directory for local revisions to the gitignore.

Changes in the Dependencies:

  • Removed esprima since it was not used
  • @types/debug is now in sync with the version of debug. Before it was 0.0.31 vs. 4
  • @types/rimraf is now in sync with the version of rimraf. Before it was 2.0.2 vs. 3.0.2
  • Major version bumps (only dropped unsupported Node.js versions):
  • Bump electron from 9.0.0-beta.24 to 9.2.1 (now its at least a stable release. version 10 is the latest one, should we use that?)

The failing bot is unrelated.

"ncp": "^2.0.0",
"node-stream-zip": "^1.8.2",
"node-stream-zip": "^1.11.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the minor/patch components should have no effect here. Maybe when bumping major version component for the deps we should rewrite them as "1.x" instead of "^1.11.3" so that it's more clear that we don't have any constraints on the minor version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it was mostly about the minor bumps. 👍

@pavelfeldman pavelfeldman merged commit 63a0e0c into microsoft:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants