fix(connect): make selectors.register work in connected browser #3664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
Aug 27, 2020
This is a large rework of selectors: - each BrowserContext now has a separate Selectors instance that has its own registrations; - public selectors.register api iterates over all contexts and registers in each of them; - connected browser reuses Selectors instance from the parent BrowserType; - rpc methods migrated to BrowserContext.registerSelectorEngine and ElementHandle._createSelectorForTest. Selectors could be per-browser, but launchPersistentContext does not report a Browser over rpc, so it has to be per-context now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large rework of selectors:
sharedSelectorsinstance, but contexts created for a connected browser have their own instance.RemoteBrowserobject that encapsulates Selectors and Browser. This Selectors object is registered with the api selectors.selectors.registerapi iterates over all registered Selectors channels and registers in each of them.ElementHandle._createSelectorForTest.