devops: align release publishing of docker image with dev releases #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Sep 2, 2020
mxschmitt
approved these changes
Sep 2, 2020
| docker tag playwright:localbuild playwright.azurecr.io/public/playwright:${TAG_NAME} | ||
| docker rmi playwright:localbuild | ||
| # push image to registry | ||
| docker push playwright.azurecr.io/public/playwright:latest |
There was a problem hiding this comment.
Since we are only tagging the latest/bionic/v1.30 and not pushing all of them it will result that only latest (playwright.azurecr.io/public/playwright:latest) gets updated on the Docker registry. Is this intended?
(You would need to add two more docker push calls then for the other tags)
There was a problem hiding this comment.
Ah, that's right! I think we can push the repo itself and it'll push all the tags. Let's try on the dev release first.
aslushnikov
force-pushed
the
devops-align-release-process-for-dev-and-release-docker-images
branch
from
86d584d
to
767cdcd
Compare
This patch starts using the same approach to docker publishing that we currently use to publish canary docker images.
aslushnikov
force-pushed
the
devops-align-release-process-for-dev-and-release-docker-images
branch
from
767cdcd
to
09a83a0
Compare
aslushnikov
deleted the
devops-align-release-process-for-dev-and-release-docker-images
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch starts using the same approach to docker publishing that we
currently use to publish canary docker images.