Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(screencast): try to unflake tests #3742

Merged
merged 2 commits into from
Sep 2, 2020
Merged

test(screencast): try to unflake tests #3742

merged 2 commits into from
Sep 2, 2020

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Sep 2, 2020 •
edited
Loading

  • Use chromium instead of Firefox for replaying WebKit screencast on the platforms where WebKit doesn't play vp8.
  • Increase recording wait times to 1s
  • Wait for the first screencast event in the popup test before crontinuing to opening popup.

#1158

@yury-s yury-s merged commit 469541a into microsoft:master Sep 2, 2020
@yury-s yury-s deleted the screencast-test-unflake branch September 2, 2020 22:22
@mxschmitt mxschmitt mentioned this pull request May 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslushnikov aslushnikov aslushnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yury-s @aslushnikov