devops: encode build number together with Chromium revision #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternative approach to microsoft#3698 that was setting up a custom mapping between chromium revisions and our mirrored builds. One big downside of the opaque mapping was inability to quickly understand which Chromium is mirrored to CDN. To solve this, this patch starts treating browser revision as a fractional number, with and integer part being a chromium revision, and fractional part being our build number. For example: - current `BUILD_NUMBER` for Chromium that we mirror to our CDN is `792639`. - if I want to change the packaging procedure, e.g. update bundled FFMPEG, I can change `BUILD_NUMBER` to `792639.1`. In the Playwright code itself, there are a handful of places that treat browser revision as integer, mostly to compare them with some particular revision numbers. This code would still work, but I changed these places to parse float instead for correctness.
aslushnikov
deleted the
experimental-introduce-fractional-chromium-revision
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #3698 that was setting up a custom
mapping between chromium revisions and our mirrored builds. For example, we were
taking chromium
792639and re-packaging it to our CDN as Chromium 1000.One big downside of this opaque mapping was inability to quickly
understand which Chromium is mirrored to CDN.
To solve this, this patch starts treating browser revision as a fractional number,
with and integer part being a chromium revision, and fractional
part being our build number. For example, we can generate builds
792639,792639.1,792639.2etc, all of which will pick Chromium792639and re-package it to our CDN.In the Playwright code itself, there are a handful of places that treat
browser revision as integer, exclusively to compare revision with some particular
revision numbers. This code would still work as-is, but I changed these places
to use
parseFloatinstead ofparseIntfor correctness.