browser(firefox): fix automatic http->https redirect #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, Firefox does an automatic http->https redirect without hitting the network (e.g. for http://wikipedia.org). In this case, the http request is very strange: - it does not actually hit the network; - it is never intercepted; - we cannot access its response because there was no actual response. So, we had a bug where: - redirects inherited the original request's listener; - that listener was throwing an error. This lead to the error in the listeners onDataAvailable call chain, and original listener that renders the response was never called, resulting in an empty page. This change fixes both issues: we do not inherit the listener and also try/catch problematic calls. There is still an issue that we cannot intercept such a request.
pavelfeldman
approved these changes
Sep 9, 2020
aslushnikov
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, Firefox does an automatic http->https redirect without hitting
the network (e.g. for http://wikipedia.org). In this case, the http request
is very strange:
So, we had a bug where:
This lead to the error in the listeners onDataAvailable call chain,
and original listener that renders the response was never called,
resulting in an empty page.
This change:
Fixes #3776