-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests for request event and interception with redirects #3994
tests for request event and interception with redirects #3994
Conversation
The network interception in Playwright is implemented on the Browser -> Network stack boundary. Once the request is in the network stack, it is going to handle the redirects and report them, but not allow intercepting them. So while this is a limitation, it is currently considered to be 'as-designed'. |
Ah right that’s unfortunate. The test for redirects and the request event might still be useful. Happy to remove the intercept one. Also would be good to clarify this in the docs. Is there a way of providing an allow list on urls that can be accessed (including redirects) and block the rest? Thanks |
4ca7d17
to
7c00b0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a minor comment in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Looks great, merging it 🚀
See #3993
This adds a
currently failingtest for intercepting a request that redirects. The interceptor is not called for the redirect.