fix(listeners): avoid "too many listeners" problem safely #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/server/processLauncher.ts
Outdated
| @@ -58,6 +58,10 @@ export async function gracefullyCloseAll() { | |||
| await Promise.all(Array.from(gracefullyCloseSet).map(gracefullyClose => gracefullyClose().catch(e => {}))); | |||
| } | |||
|
|
|||
| // We currently spawn a process per page when recording video in Chromium. | |||
| // This triggers "too many listeners" on the process object once you have more than 10 pages open. | |||
| process.setMaxListeners(100); | |||
There was a problem hiding this comment.
Suggested change
| process.setMaxListeners(100); | |
| process.setMaxListeners(0); |
JoelEinbinder
approved these changes
Oct 23, 2020
pavelfeldman
force-pushed
the
revert101
branch
from
960eccd to
ad59636
Compare
aslushnikov
pushed a commit
that referenced
this pull request
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4224