Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): put browser deps instructions first #4637

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Dec 8, 2020

The dependencies part should be common between language bindings and this way it should be easier to compare.

@yury-s yury-s requested a review from aslushnikov December 8, 2020 18:25
Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's maybe also put the # 3. Symlink downloaded browsers for root user up or would it break since the folders does not exist yet?

@yury-s
Copy link
Member Author

yury-s commented Dec 8, 2020

Let's maybe also put the # 3. Symlink downloaded browsers for root user up or would it break since the folders does not exist yet?

Yeah, it currently placed right after the instruction that creates the folder. I'm not fond of creating such link if the target directory won't be created. In any case we can change that in a separate PR, my main goal is to ensure that the Dockerfiles in language bindings have same prefix as currently the first RUN instruction will differ between typescript, python and java.

@yury-s yury-s merged commit 6c4d3b8 into microsoft:master Dec 8, 2020
@yury-s yury-s deleted the docker-rearrange branch December 8, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants