fix(trace viewer): updating default traceStorageDir value #4962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `npx playwright show-trace <tracePath>` command is executed, without providing the `resources` optional parameter, the function expected the `traceStorageDir` default value to be the same directory as in which the tracePath resides. This change updates it to the `dirname(tracePath)/trace-resources` if it exists. Such a directory hirerachy is the default that is created when running the tracer in Playwright.
|
@domderen Thank you for the PR! We usually put a "namespace" or "component" in the change description. I will go ahead and rename this PR according to the guidelines. |
dgozman
changed the title
dgozman
approved these changes
Jan 11, 2021
dgozman
reviewed
Jan 11, 2021
…rovided by user.
domderen
commented
Jan 11, 2021
dgozman
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
npx playwright show-trace <tracePath>command is executed, without providing theresourcesoptional parameter, the function expects thetraceStorageDirdefault value to be the same directory in which thetracePathresides. This change updates it to thedirname(tracePath)/trace-resourcesif it exists. Such directory hierarchy is created by Tracer by default.