docs: python api review #4986
Merged
docs: python api review #4986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
reviewed
Jan 12, 2021
docs/src/api/class-browsercontext.md
Outdated
| @@ -219,6 +225,7 @@ Whether to pass the argument as a handle, instead of passing by value. When pass | |||
| supported. When passing by value, multiple arguments are supported. | |||
|
|
|||
| ## async method: BrowserContext.exposeFunction | |||
| **DEPRECATED** Use [`method: BrowserContext.exposeBinding`] instead. | |||
There was a problem hiding this comment.
lets remove it maybe from Python directly?
There was a problem hiding this comment.
We actually considered it and decided to leave it as is. I'll remove the deprecation note.
types/types.d.ts
Outdated
| * > **NOTE** Browser context **must** be created with the `acceptDownloads` set to `true` when user needs access to the | ||
| * downloaded content. If `acceptDownloads` is not set or set to `false`, download events are emitted, but the actual | ||
| * download is not performed and user has no access to the downloaded files. | ||
| * :::note |
There was a problem hiding this comment.
this :::note isn't official markdown syntax, so shall we maybe transform it for the types and api.json so editors like VSC can display it correctly?
There was a problem hiding this comment.
Yeah, we should do it at a codegen stage, was planning on doing it later, but might as well do it right away.
pavelfeldman
force-pushed
the
python_docs3
branch
from
19c8b79 to
7015696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.