fix(dom): make selectOption wait for options #5036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
force-pushed
the
select-option-wait
branch
from
ea1cf5f to
b306626
Compare
dgozman
approved these changes
Jan 19, 2021
| if (select.multiple) { | ||
| remainingOptionsToSelect = remainingOptionsToSelect.filter(o => !filter(o)); | ||
| } else { | ||
| remainingOptionsToSelect = []; |
There was a problem hiding this comment.
This logic seems strange. I guess we should throw when multiple options are passed for non-multiple select? Otherwise there is no way we select them all.
There was a problem hiding this comment.
From our docs: " If the has the multiple attribute, all matching options are selected, otherwise only the first option matching one of the passed options is selected."
yury-s
force-pushed
the
select-option-wait
branch
from
9ae2edd to
e86354c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we'd use
InjectedScriptPollHandlerfor polling options but that may result in an exception if selecting an option triggers navigation.Fixes #4921