browser(webkit): fix scrolling a second time on linux #5173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty sure GTK/WPE didn't work without this patch. From #2508 it sounds like the problem was with screencast in WPE, does it now work without this code? |
|
All tests pass when I delete it. If theres another way to repro let me know please. |
JoelEinbinder
force-pushed
the
wk_fix_scroll
branch
from
c46fb12 to
e71f865
Compare
|
I've tried locally with cnn.com and github.com and iphone 11 emulation and didn't find any issues with video recording. The code would only run on the first window.scrollBy call though. |
JoelEinbinder
force-pushed
the
wk_fix_scroll
branch
from
e71f865 to
1d60b9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code doesn't appear to be needed. All tests pass without it, and it breaks scrolling for #4366.