chore: update error message when using userDataDir arg #5814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Playwright users may unaware of the proper way to set the browser's
`userDataDir`. Currently, calling `launch({args: ['--userDataDir=...']})`
throws shows users an error message, leading some to try
`launch({userDataDir})`, which also throws and shows a different error
message, leading users to the proper invocation,
`launchPersistentContext(userDataDir, ...)`.
This change updates the first error message's text to hopefully hint users to
the proper invocation more quickly.
|
|
yury-s
approved these changes
Mar 13, 2021
|
Thanks for merging this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Playwright users may unaware of the proper way to set the browser's
userDataDir. Currently, callinglaunch({args: ['--userDataDir=...']})throws shows users an error message, leading some to try
launch({userDataDir}), which also throws and shows a different errormessage, leading users to the proper invocation,
launchPersistentContext(userDataDir, ...).This change updates the first error message's text to hopefully hint users to
the proper invocation more quickly.