Update error message to point to existing docs #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change edits the suggested documentation message so that it points to a valid URL. It makes sense that eventually we should write a troubleshooting doc. In the meantime, I think this is a reasonable alternative. Happy to point it somewhere else if it's desired.
yury-s
reviewed
Jan 23, 2020
| @@ -166,7 +166,7 @@ export function waitForLine(process: childProcess.ChildProcess, inputStream: str | |||
| 'Failed to launch browser!' + (error ? ' ' + error.message : ''), | |||
| stderr, | |||
| '', | |||
| 'TROUBLESHOOTING: https://github.com/Microsoft/playwright/blob/master/docs/troubleshooting.md', | |||
There was a problem hiding this comment.
Let's drop this line altogether as it makes little sense for troubleshooting anyway? We can refine the message later once we have meaningful instructions.
|
Thanks for the PR! I have a competing patch at #605 |
|
Closing this in favor of #605: we do need troubleshooting, it's pretty helpful. |
|
Thanks all! |
sand4rt
pushed a commit
to sand4rt/playwright
that referenced
this pull request
Dec 21, 2022
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change edits the suggested documentation message so that it points to a valid URL.
It makes sense that eventually we should write a troubleshooting doc. In the meantime, I think this is a reasonable alternative. Happy to point it somewhere else if it's desired.