Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): export playwright-core types from playwright #628

Merged
merged 1 commit into from
Jan 25, 2020
Merged

fix(types): export playwright-core types from playwright #628

merged 1 commit into from
Jan 25, 2020

Conversation

jperl
Copy link
Contributor

@jperl jperl commented Jan 24, 2020

Resolves #627

I tested this works locally with npm link.

@dgozman dgozman requested a review from JoelEinbinder January 24, 2020 19:08
Copy link
Contributor

@JoelEinbinder JoelEinbinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revisit this with #6.

@pavelfeldman pavelfeldman merged commit 63d5a73 into microsoft:master Jan 25, 2020
@jperl jperl deleted the fix-playwright-types branch January 25, 2020 01:29
sand4rt pushed a commit to sand4rt/playwright that referenced this pull request Dec 21, 2022
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types exported from playwright-core, but not playwright
3 participants