Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support relative downloadsPath directory for downloads #6402

Merged

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented May 4, 2021

Before this change there were two issues:

  • On Windows it was not working at all when a relative download path was passed
  • Artifact.path() -> Download.path() returned the relative path + uuid, it returns now it's absolute variant to be consistent with the behavior when an absolute path was given

Fixes #6401

@mxschmitt mxschmitt marked this pull request as draft May 4, 2021 11:57
@mxschmitt mxschmitt changed the title test: add test for relative downloadsPath folder fix: support relative downloadsPath directory for downloads May 4, 2021
@mxschmitt mxschmitt marked this pull request as ready for review May 4, 2021 12:48
@mxschmitt mxschmitt requested a review from dgozman May 4, 2021 13:00
Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather resolve the path in validateLaunchOptions and assume absolute path throughout the rest of the code. This way we won't need any changes in Artifact or launch.

@mxschmitt mxschmitt requested a review from dgozman May 5, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] relative downloadsPath does not work on Windows
2 participants