feat(devices): add more Android device descriptions #6413
Merged
+120
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds device descriptions for: * Galaxy S8 * Galaxy S9+ * Galaxy Tab S4 * Pixel 3 * Pixel 4 These devices are regarded as worthy of targeting by [BrowserStack](https://www.browserstack.com/test-on-the-right-mobile-devices). Sources (both have identical data for these 5 devices): 1. https://github.com/aerokube/moon-deploy/blob/master/moon-local.yaml#L199 2. https://www.danhendricks.com/2018/04/adding-iphone-galaxy-chrome-mobile-emulated-devices/#heading_device_data
|
|
mxschmitt
approved these changes
May 5, 2021
There was a problem hiding this comment.
LGTM, should be helpful since these are currently common devices. Running npm run build locally should regenerate the types which is the reason that the GitHub Actions Status-Check is currently failing.
(No worries regarding the commit message style, we can squash and adjust it.)
Thanks @mxschmitt, done! |
|
Let me rename the PR according to the guidelines. |
dgozman
changed the title
devtools-bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
Sep 11, 2021
Adds: Galaxy S8 Galaxy S9+ Galaxy Tab S4 Pixel 3 Pixel 4 These devices are regarded as worthy of targeting by https://www.browserstack.com/test-on-the-right-mobile-devices Sources (both have identical data for these 5 devices): 1. https://github.com/aerokube/moon-deploy/blob/master/moon-local.yaml#L199 2. https://www.danhendricks.com/2018/04/adding-iphone-galaxy-chrome-mobile-emulated-devices/#heading_device_data The same changes (structured differently) have been added to Playwright ( microsoft/playwright#6413 ). This PR was suggested by @mathiasbynens, see puppeteer/puppeteer#7210 Change-Id: I70db28b15b77fcdb82171a08ebd0b33aa0886621 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2919612 Reviewed-by: Jan Scheffler <janscheffler@chromium.org> Reviewed-by: Changhao Han <changhaohan@chromium.org> Reviewed-by: Peter Müller <petermueller@chromium.org> Reviewed-by: Mraz Marian <mraz@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Paul Lewis <aerotwist@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds device descriptions for:
These devices are regarded as worthy of targeting by BrowserStack.
Sources (both have identical data for these 5 devices):
PS: Whoops, forgot to "follow the Semantic Commit Messages format", I can fix that tomorrow if necessary.