Example of broken types #692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperl
added a commit
to qawolf/qawolf
that referenced
this pull request
Jan 28, 2020
relates to microsoft/playwright#692
|
Alternatively if there were tests written with typescript they would also catch this kind of issue. |
|
ah, that's a great finding! Thanks a lot! Addressed this in #698 |
|
Oh wait, I checked your code first and saw the wrong export that we did for device descriptors - this is fixed now. However, this is something more involved than I initially thought. 🧐cc @JoelEinbinder |
|
Thanks for the quick response. At first I was going to submit a PR with all the fixes, but I kept running into other types issues and ran out of time before a gym class. This PR resolves the build issue #699 However I think having the tests in typescript would prevent future whack-a-mole types issues like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not intended to be merged, just an example of a top level export issue and types issue with
playwright-core@0.9.23and typescript.If you try to run
npm run buildin theplaywright-test-typespackage you will see the types errorI think it would be useful to have a test that
playwrightcan be imported by a typescript package and built, and to test top level exports like playwright.devices work.I would be happy to add this test, if you could point me in the right direction of how you would like it to work with the test runner.