Validate web site preview URL #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitjoshi438
approved these changes
Jul 25, 2024
ashishchoudhary001
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes aimed at improving localization, refining telemetry event handling, and refactoring the ArtemisService and related components. The most important changes include updates to localization files, new telemetry events, and significant refactoring of the ArtemisService to improve functionality and maintainability.
Localization Updates:
l10n/bundle.l10n.json: Added a new localization string for "Preview site URL is not valid".loc/translations-export/vscode-powerplatform.xlf: Added a new translation unit for "Preview site URL is not valid".Telemetry Enhancements:
src/common/OneDSLoggerTelemetry/web/client/webExtensionTelemetryEvents.ts: Added new telemetry events for website preview URL validation. [1] [2]ArtemisService Refactoring:
src/common/services/ArtemisService.ts: Refactored ArtemisService to replacefetchArtemisResponsewithgetArtemisResponse, and updated related methods to improve response handling. [1] [2] [3] [4]src/client/extension.ts: Updated usage of ArtemisService to align with the newgetArtemisResponsemethod. [1] [2]Constants and Interfaces Updates:
src/common/services/Constants.ts: Introduced new constants and enums for Power Platform API and refactored existing ones for better clarity. [1] [2]src/common/services/Interfaces.ts: Updated interfaces to reflect changes in service endpoint categories and added a new interface for website details. [1] [2]Miscellaneous:
src/common/services/AuthenticationProvider.ts: Added a new function for Power Platform API authentication and updated telemetry event handling. [1] [2]src/common/services/BAPService.ts: Refactored BAPService to use the new service endpoint categories. [1] [2]