Extending the name sanitization done on file names to folder names which are based on entity name values #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich are based on entity name values
tyaginidhi
requested review from
ashishchoudhary001,
amitjoshi438 and
BidishaMS
Merged
BidishaMS
approved these changes
Aug 11, 2023
ashishchoudhary001
approved these changes
Aug 11, 2023
tehcrashxor
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File names used to for files loaded in file explorer is already sanitized. But, for entities like webpages, and advanced forms - we do not sanitize the folder name currently - which is also based on Name parameter fetched from entity records. This is an optimization PR based on the exceptions monitoring.