Always trigger activation path load of folders - fix race condition on preemptive root directory creation #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n preemptive root directory creation
tyaginidhi
requested review from
ashishchoudhary001,
BidishaMS and
amitjoshi438
Merged
ashishchoudhary001
approved these changes
Aug 11, 2023
BidishaMS
approved these changes
Aug 11, 2023
tehcrashxor
approved these changes
Aug 11, 2023
tyaginidhi
deleted the
users/nityagi/RaceConditionFixForRootFolderBasedRead
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a race condition where while we pro-actively load a file open in editor from a previous session, the load entire power pages code path is not triggered, This happens as the load of already open file flow creates the root directory, and hence the readDirectory flow for first time data load is not hit as entry is already present.