Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ADL for free function accessors #220

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Fix ADL for free function accessors #220

merged 2 commits into from
Dec 16, 2024

Conversation

mingxwa
Copy link
Collaborator

@mingxwa mingxwa commented Dec 15, 2024

Changes

  • Exposed proxy_indirect_accessor as a public API and added documentation.
  • Revised the implementation of ___PRO_DEF_FREE_ACCESSOR_TEMPLATE to use std::conditional_t<C::is_direct, proxy<F>, proxy_indirect_accessor<F>> (details::adl_accessor_arg_t) rather than accessor as the type of the operand to perform ADL correctly.
  • Added a unit test case for this change.
  • Revised related spec accordingly.

Resolves #219

@mingxwa mingxwa requested review from tian-lt and guominrui December 15, 2024 03:02
tian-lt
tian-lt approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@tian-lt tian-lt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingxwa mingxwa merged commit a6835a2 into microsoft:main Dec 16, 2024
7 checks passed
@mingxwa mingxwa deleted the user/mingxwa/fix-adl branch December 16, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guominrui guominrui guominrui approved these changes

@tian-lt tian-lt tian-lt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PRO_DEF_FREE_DISPATCH fails to perform ADL
3 participants
@mingxwa @tian-lt @guominrui