Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

DAP: Stop on entry should be ported to pydevd #1418

Closed
fabioz opened this issue May 13, 2019 · 3 comments · Fixed by #1415
Closed

DAP: Stop on entry should be ported to pydevd #1418

fabioz opened this issue May 13, 2019 · 3 comments · Fixed by #1415
Assignees
@karthiknadig
Labels
DAP pydevd Refactor Unplanned-work Upstream-pydevd
Milestone
May 2019.1

Comments

@fabioz
Copy link
Contributor

fabioz commented May 13, 2019

Blocked by:

#1387
#1413
@karthiknadig
Copy link
Member

I might be able to move this fairly easily with the #1387 change. It looks straight forward.

@fabioz
Copy link
Contributor Author

fabioz commented May 13, 2019

Sure... some things to check though:

  • We should add an API to do the stop on entry in PyDevdAPI.
  • There is actually a command CMD_STOP_ON_START already (implemented in PyDevdAPI.cmd_stop_on_start) -- it should use the new API (not sure why ptvsd wasn't using it already).
  • Processing the debug adapter settings (in _PyDevJsonCommandProcessor._set_debug_options) should use the new API.

-- if you want to implement this along with that change, feel free to do it ;)

@karthiknadig
Copy link
Member

Ok. I will push an update to the PR.

@karthiknadig karthiknadig self-assigned this May 13, 2019
@karthiknadig karthiknadig added this to the May 2019.1 milestone May 13, 2019
karthiknadig added a commit to karthiknadig/ptvsd that referenced this issue May 14, 2019
@karthiknadig
Fix microsoft#1418 and clean up
ae0417c
@karthiknadig karthiknadig mentioned this issue May 14, 2019
Merged
karthiknadig added a commit to karthiknadig/ptvsd that referenced this issue May 14, 2019
@karthiknadig
Fix microsoft#1418 and clean up
9574cb6
karthiknadig added a commit that referenced this issue May 14, 2019
@karthiknadig
Ensure stop on entry reason is entry. Fixes #1387 (#1415)
3e89bde 
* Ensure that stopped reason is 'entry' for stop on entry.

* Update cython wrappers

* Revert "Update cython wrappers"

This reverts commit d98efe2.

* Generate .pyx and .c files.

* Update name

* .

* Update tests

* preserveFocusHint should be false for `entry`

* Fix #1418 and clean up

* Add log message if no main thread is found
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karthiknadig karthiknadig

Labels
DAP pydevd Refactor Unplanned-work Upstream-pydevd
Projects
None yet
Milestone
May 2019.1
Development

Successfully merging a pull request may close this issue.

Ensure stop on entry reason is entry. Fixes #1387 karthiknadig/ptvsd
2 participants
@fabioz @karthiknadig