Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Changes in CLI arguments between versions #896

Closed
DonJayamanne opened this issue Oct 10, 2018 · 7 comments
Closed

Changes in CLI arguments between versions #896

DonJayamanne opened this issue Oct 10, 2018 · 7 comments

Comments

@DonJayamanne
Copy link
Contributor

Environment data

  • PTVSD version: 4.1.3
  • Using VS Code or Visual Studio: N/A

Actual behavior

  • CLI args for starting apps for remote debugging has changed
  • Now the arg requires --server-host, this wasn't the case in the past.
  • This is a breaking change.

Expected behavior

  • We need to revert if possible as existing users will not be able to use PTSVD for remote debugging scenarios.

Reported here microsoft/vscode-python#2833 (comment)

@DonJayamanne
Copy link
Contributor Author

Please feel free to change the Priority label.

@jarshwah
Copy link

FWIW I think the --server-host came in on the previous version? I could not get remote debugging working with 2018.8.0 / 4.1.2, and specifically waited for these combination of versions to work again, so please don't just revert if you can manage it.

@DonJayamanne
Copy link
Contributor Author

so please don't just revert if you can manage it.

No decision had been made yet.

@jarshwah
Copy link

Sorry, I realised that, just providing a bit of extra context. I'm super excited to have remote debugging for django in docker!

@karthiknadig karthiknadig added this to the Oct 2018.2 milestone Oct 10, 2018
int19h added a commit to int19h/ptvsd that referenced this issue Oct 12, 2018
Remove --server-host. Server mode is always implied by default now in all circumstances, and --client is used to specify client mode.
int19h added a commit that referenced this issue Oct 12, 2018
Remove --server-host. Server mode is always implied by default now in all circumstances, and --client is used to specify client mode.
@DonJayamanne
Copy link
Contributor Author

@int19h
I've tried debugging with the master branch of PTVSD using the following args:
python -m ptvsd --port 5678 sample.py

It doesn't seem to work.
I.e. I cannot seem to connect to the remote machine. I need to add --server-host 0.0.0.0 to get it working.

@karthiknadig
Copy link
Member

Verify using this branch v4.1.4-branch

@DonJayamanne
Copy link
Contributor Author

Oops, tested there too, no luck.
Have to use --host 0.0.0.0 for it to work.

int19h added a commit to int19h/ptvsd that referenced this issue Oct 18, 2018
Merge changes from v4.1.4-branch into master.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants