This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Stacktrace contains xml escaped characters. Fix #948, #981 #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
changed the title
Codecov Report
@@ Coverage Diff @@
## master #996 +/- ##
==========================================
- Coverage 53.4% 53.29% -0.11%
==========================================
Files 33 33
Lines 4425 4430 +5
==========================================
- Hits 2363 2361 -2
- Misses 2062 2069 +7
Continue to review full report at Codecov.
|
int19h
reviewed
Nov 8, 2018
| assert compare_path(frames[0]['source']['path'], testfile) | ||
|
|
||
| debug_session.send_request('continue').wait_for_response() | ||
| debug_session.wait_for_next(Event('continued')) |
There was a problem hiding this comment.
This should probably be expect_new (wait_for_next will work as well, but it'll time out waiting if the event wasn't there, whereas expect_new will fail immediately).
There was a problem hiding this comment.
expect_new seems to trip over the response to continue request.
AssertionError: assert [22!Request('continue', None), 23!Response(22!Request('continue', None), {'allThreadsContinued': True})] is ('not matching expectation', Event('continued', ANY))
int19h
approved these changes
Nov 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #948, Fixes #981