Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix simulator build #1460

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix simulator build #1460

merged 2 commits into from
Dec 7, 2023

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Dec 7, 2023

Not sure why this broke all of a sudden; seems like the build started randomly including the node typings. I expect it's a change in a dependency.

@riknoll riknoll requested review from kimprice and a team December 7, 2023 23:41
@riknoll riknoll merged commit 4e7d8c5 into master Dec 7, 2023
3 checks passed
@riknoll riknoll deleted the dev/riknoll/fix-build branch December 7, 2023 23:45
kimprice pushed a commit that referenced this pull request Dec 8, 2023
@riknoll @kimprice
Fix simulator build (#1460)
637e85f 
* remove type roots

* try to exclude node types
@kimprice kimprice mentioned this pull request Dec 8, 2023
Merged
abchatra pushed a commit that referenced this pull request Dec 8, 2023
@kimprice @riknoll
[stable10.3] Cherry pick: Change img field editor to sprite (#1459) (#…
d9a3d79 
…1461)

* change img field editor to sprite (#1459)

* Fix simulator build (#1460)

* remove type roots

* try to exclude node types

---------

Co-authored-by: Richard Knoll <riknoll@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimprice kimprice kimprice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riknoll @kimprice