Remove global search path cache #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erictraut
reviewed
Mar 12, 2021
| @@ -29,8 +29,6 @@ interface PythonPathResult { | |||
| prefix: string; | |||
| } | |||
|
|
|||
| const cachedSearchPaths = new Map<string, PythonPathResult>(); | |||
There was a problem hiding this comment.
I think we're caching enough in the import resolver that the removal of this cache won't matter. Out of curiosity, did you do any benchmarking to confirm this?
There was a problem hiding this comment.
I haven't; I can try and clone your team's repo to test.
Note that the import resolver is already caching this call explicitly (was before per venv though that code got modified), so I wouldn't expect it to have changed.
There was a problem hiding this comment.
I can't find your repo anymore, but on typeshed there is no difference in the numbers I get when using --stats.
There was a problem hiding this comment.
I'm not that concerned about it. I can test it after you land this change.
erictraut
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to this function only happen either on settings update (we do a bunch of work scanning files for other reasons that are no slower than calling Python), or in the import resolver (which has a cache for this call explicitly). Remove this cache so that editable installs modified while the LS is running are properly handled.
Last thing to finish microsoft/pylance-release#78.