Ensure default version and platform only once #8802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erictraut
approved these changes
Aug 21, 2024
This comment has been minimized.
This comment has been minimized.
|
Okay that had a lot more impact than I thought. Must have missed something. |
|
Defaults were implicitly being used in the execution environments. Need to update to take that into account. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: pydantic (https://github.com/pydantic/pydantic)
- /tmp/mypy_primer/projects/pydantic/pydantic/functional_validators.py:21:10 - warning: Import "typing_extensions" could not be resolved from source (reportMissingModuleSource)
- /tmp/mypy_primer/projects/pydantic/pydantic/_internal/_typing_extra.py:37:10 - warning: Import "typing_extensions" could not be resolved from source (reportMissingModuleSource)
- 265 errors, 47 warnings, 0 informations
+ 265 errors, 45 warnings, 0 informations
pandera (https://github.com/pandera-dev/pandera)
- /tmp/mypy_primer/projects/pandera/pandera/api/dataframe/container.py:34:10 - warning: Import "typing_extensions" could not be resolved from source (reportMissingModuleSource)
- /tmp/mypy_primer/projects/pandera/pandera/engines/engine.py:33:10 - warning: Import "typing_extensions" could not be resolved from source (reportMissingModuleSource)
- /tmp/mypy_primer/projects/pandera/pandera/engines/pandas_engine.py:86:10 - warning: Import "typing_extensions" could not be resolved from source (reportMissingModuleSource)
+ /tmp/mypy_primer/projects/pandera/pandera/io/pandas_io.py:338:19 - error: Argument of type "Unknown | None" cannot be assigned to parameter "args" of type "StrPath" in function "__init__" (reportArgumentType)
- /tmp/mypy_primer/projects/pandera/tests/core/test_dtypes.py:38:10 - warning: Import "typing_extensions" could not be resolved from source (reportMissingModuleSource)
- 2451 errors, 23 warnings, 0 informations
+ 2452 errors, 19 warnings, 0 informations
steam.py (https://github.com/Gobot1234/steam.py)
- /tmp/mypy_primer/projects/steam.py/poetry_build.py:8:12 - error: Import "tomllib" could not be resolved (reportMissingImports)
- /tmp/mypy_primer/projects/steam.py/poetry_build.py:14:13 - error: Type of "loads" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/steam.py/poetry_build.py:14:13 - error: Type of "loads" is partially unknown
+ Type of "loads" is "((s: str, /, *, parse_float: ((str) -> Any) = ...) -> dict[str, Any]) | Unknown" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/scripts/blacken_docs_correctly.py:20:12 - error: Import "tomllib" could not be resolved (reportMissingImports)
- /tmp/mypy_primer/projects/steam.py/scripts/blacken_docs_correctly.py:33:21 - error: Type of "load" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/steam.py/scripts/blacken_docs_correctly.py:33:21 - error: Type of "load" is partially unknown
+ Type of "load" is "((fp: SupportsRead[bytes], /, *, parse_float: ((str) -> Any) = ...) -> dict[str, Any]) | Unknown" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/scripts/blacken_docs_correctly.py:35:31 - error: Type of "get" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/steam.py/scripts/blacken_docs_correctly.py:35:31 - error: Type of "get" is partially unknown
+ Type of "get" is "Overload[(key: str, /) -> (Any | None), (key: str, default: Any, /) -> Any, (key: str, default: _T@get, /) -> (Any | _T@get)] | Unknown" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/scripts/blacken_docs_correctly.py:35:31 - error: Type of "get" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/steam.py/scripts/blacken_docs_correctly.py:35:31 - error: Type of "get" is partially unknown
+ Type of "get" is "Any | Unknown" (reportUnknownMemberType)
- Type of "get" is "Unknown | Overload[(key: str, /) -> (Any | None), (key: str, default: Any, /) -> Any, (key: str, default: _T@get, /) -> (Any | _T@get)]" (reportUnknownMemberType)
+ Type of "get" is "Overload[(key: str, /) -> (Any | None), (key: str, default: Any, /) -> Any, (key: str, default: _T@get, /) -> (Any | _T@get)] | Unknown" (reportUnknownMemberType)
- Type of "get" is "Unknown | Overload[(key: str, /) -> (Any | None), (key: str, default: Any, /) -> Any, (key: str, default: _T@get, /) -> (Any | _T@get)]" (reportUnknownMemberType)
+ Type of "get" is "Overload[(key: str, /) -> (Any | None), (key: str, default: Any, /) -> Any, (key: str, default: _T@get, /) -> (Any | _T@get)] | Unknown" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/steam/client.py:39:60 - error: "TaskGroup" is unknown import symbol (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/steam.py/steam/client.py:39:71 - error: "timeout" is unknown import symbol (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/steam.py/steam/client.py:306:16 - error: Type of "_tg" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/steam/client.py:306:16 - error: Type of "create_task" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/steam/client.py:356:9 - error: Type of "_tg" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/steam/client.py:358:15 - error: Type of "_tg" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/steam/client.py:358:15 - error: Type of "__aenter__" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/steam/client.py:365:19 - error: Type of "_tg" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/steam/client.py:365:19 - error: Type of "__aexit__" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/steam/client.py:451:13 - error: Type of "_tg" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/steam/client.py:460:57 - error: Type of "_tg" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/steam/client.py:501:21 - error: Type of "_tg" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/steam/client.py:501:21 - error: Type of "create_task" is unknown (reportUnknownMemberType)
- /tmp/mypy_primer/projects/steam.py/steam/gateway.py:36:86 - error: "timeout" is unknown import symbol (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/steam.py/steam/http.py:14:67 - error: "Unpack" is unknown import symbol (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/steam.py/steam/http.py:56:42 - error: Type of parameter "options" is unknown (reportUnknownParameterType)
- Type of "get" is "Overload[(key: str, /) -> (Unknown | None), (key: str, default: Unknown, /) -> Unknown, (key: str, default: _T@get, /) -> (Unknown | _T@get)]" (reportUnknownMemberType)
+ Type of "get" is "Overload[(k: Literal['proxy']) -> (str | None), (k: Literal['proxy'], default: str | __TDefault@ClientKwargs | None) -> (str | __TDefault@ClientKwargs | None), (k: Literal['proxy_auth']) -> (Unknown | None), (k: Literal['proxy_auth'], default: Unknown | __TDefault@ClientKwargs | None) -> (Unknown | __TDefault@ClientKwargs | None), (k: Literal['connector']) -> (Unknown | None), (k: Literal['connector'], default: Unknown | __TDefault@ClientKwargs | None) -> (Unknown | __TDefault@ClientKwargs | None), (k: Literal['intents']) -> (Intents | None), (k: Literal['intents'], default: Intents | __TDefault@ClientKwargs) -> (Intents | __TDefault@ClientKwargs), (k: Literal['max_messages']) -> (int | None), (k: Literal['max_messages'], default: int | __TDefault@ClientKwargs | None) -> (int | __TDefault@ClientKwargs | None), (k: Literal['app']) -> (App[str | None] | None), (k: Literal['app'], default: App[str | None] | __TDefault@ClientKwargs | None) -> (App[str | None] | __TDefault@ClientKwargs | None), (k: Literal['apps']) -> (list[App[str | None]] | None), (k: Literal['apps'], default: list[App[str | None]] | __TDefault@ClientKwargs) -> (list[App[str | None]] | __TDefault@ClientKwargs), (k: Literal['state']) -> (PersonaState | None), (k: Literal['state'], default: PersonaState | __TDefault@ClientKwargs) -> (PersonaState | __TDefault@ClientKwargs), (k: Literal['ui_mode']) -> (UIMode | None), (k: Literal['ui_mode'], default: UIMode | __TDefault@ClientKwargs) -> (UIMode | __TDefault@ClientKwargs), (k: Literal['flags']) -> (PersonaStateFlag | None), (k: Literal['flags'], default: PersonaStateFlag | __TDefault@ClientKwargs) -> (PersonaStateFlag | __TDefault@ClientKwargs), (k: Literal['force_kick']) -> (bool | None), (k: Literal['force_kick'], default: bool | __TDefault@ClientKwargs) -> (bool | __TDefault@ClientKwargs), (k: Literal['language']) -> (Language | None), (k: Literal['language'], default: Language | __TDefault@ClientKwargs) -> (Language | __TDefault@ClientKwargs), (k: Literal['auto_chunk_chat_groups']) -> (bool | None), (k: Literal['auto_chunk_chat_groups'], default: bool | __TDefault@ClientKwargs) -> (bool | __TDefault@ClientKwargs), (k: Literal['ssl']) -> (SSLContext | Unknown | Literal[False] | None), (k: Literal['ssl'], default: SSLContext | Unknown | __TDefault@ClientKwargs | Literal[False]) -> (SSLContext | Unknown | __TDefault@ClientKwargs | Literal[False]), (k: str) -> (Any | None), (k: str, default: Any | __TDefault@ClientKwargs) -> (Any | __TDefault@ClientKwargs)]" (reportUnknownMemberType)
- Type of "get" is "Overload[(key: str, /) -> (Unknown | None), (key: str, default: Unknown, /) -> Unknown, (key: str, default: _T@get, /) -> (Unknown | _T@get)]" (reportUnknownMemberType)
... (truncated 35 lines) ...
xarray (https://github.com/pydata/xarray)
- /tmp/mypy_primer/projects/xarray/xarray/core/treenode.py:33:29 - error: Argument of type "type[PurePosixPath]" cannot be assigned to parameter "cls" of type "type[Self@NodePath]" in function "__new__"
- Type "type[PurePosixPath]" is incompatible with type "type[Self@NodePath]" (reportArgumentType)
- /tmp/mypy_primer/projects/xarray/xarray/core/types.py:25:14 - warning: Import "typing_extensions" could not be resolved from source (reportMissingModuleSource)
- /tmp/mypy_primer/projects/xarray/xarray/namedarray/core.py:90:14 - warning: Import "typing_extensions" could not be resolved from source (reportMissingModuleSource)
- 2405 errors, 107 warnings, 0 informations
+ 2404 errors, 105 warnings, 0 informations
dd-trace-py (https://github.com/DataDog/dd-trace-py)
+ /tmp/mypy_primer/projects/dd-trace-py/setup.py:75:25 - error: Argument of type "str | None" cannot be assigned to parameter "args" of type "StrPath" in function "__init__" (reportArgumentType)
+ Type "None" is incompatible with type "StrPath"
+ "None" is incompatible with "str"
+ "None" is incompatible with protocol "PathLike[str]"
+ "__fspath__" is not present (reportArgumentType)
+ /tmp/mypy_primer/projects/dd-trace-py/setup.py:159:29 - error: Argument of type "None" cannot be assigned to parameter "args" of type "StrPath" in function "__init__"
- /tmp/mypy_primer/projects/dd-trace-py/benchmarks/bm/iast_fixtures/module_functions.py
- /tmp/mypy_primer/projects/dd-trace-py/benchmarks/bm/iast_fixtures/module_functions.py:25:20 - error: "splitroot" is not a known attribute of module "os.path" (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/appsec/_iast/_taint_tracking/aspects.py:590:24 - error: "splitroot" is not a known attribute of module "os.path" (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/appsec/_iast/_taint_tracking/_vendor/pybind11/pybind11/setup_helpers.py:496:26 - error: Argument of type "(self: CCompiler, sources: list[str], output_dir: str | None = None, macros: list[_Macro] | None = None, include_dirs: list[str] | None = None, debug: bool | Literal[0, 1] = 0, extra_preargs: list[str] | None = None, extra_postargs: list[str] | None = None, depends: list[str] | None = None) -> list[str]" cannot be assigned to parameter "object" of type "CCompilerMethod" in function "append"
- Type "(self: CCompiler, sources: list[str], output_dir: str | None = None, macros: list[_Macro] | None = None, include_dirs: list[str] | None = None, debug: bool | Literal[0, 1] = 0, extra_preargs: list[str] | None = None, extra_postargs: list[str] | None = None, depends: list[str] | None = None) -> list[str]" is incompatible with type "CCompilerMethod"
- Parameter 4: type "Tuple[str] | Tuple[str, str | None] | None" is incompatible with type "list[_Macro] | None" (reportArgumentType)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/contrib/internal/asyncio/patch.py:23:10 - error: Argument of type "(self: BaseEventLoop, coro: _CoroutineLike[_T@create_task], *, name: object = None) -> Task[_T@create_task]" cannot be assigned to parameter "f" of type "FunctionType" in function "wrap"
+ /tmp/mypy_primer/projects/dd-trace-py/ddtrace/contrib/internal/asyncio/patch.py:23:10 - error: Argument of type "(self: BaseEventLoop, coro: _CoroutineLike[_T@create_task], *, name: object = None, context: Context | None = None) -> Task[_T@create_task]" cannot be assigned to parameter "f" of type "FunctionType" in function "wrap"
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/contrib/internal/asyncio/patch.py:32:12 - error: Argument of type "(self: BaseEventLoop, coro: _CoroutineLike[_T@create_task], *, name: object = None) -> Task[_T@create_task]" cannot be assigned to parameter "wf" of type "WrappedFunction" in function "unwrap"
+ /tmp/mypy_primer/projects/dd-trace-py/ddtrace/contrib/internal/asyncio/patch.py:32:12 - error: Argument of type "(self: BaseEventLoop, coro: _CoroutineLike[_T@create_task], *, name: object = None, context: Context | None = None) -> Task[_T@create_task]" cannot be assigned to parameter "wf" of type "WrappedFunction" in function "unwrap"
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/internal/coverage/instrumentation_py3_10.py
+ /tmp/mypy_primer/projects/dd-trace-py/ddtrace/internal/coverage/instrumentation_py3_12.py
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/internal/coverage/instrumentation_py3_10.py:331:30 - error: "ext_instr" is possibly unbound (reportPossiblyUnboundVariable)
+ /tmp/mypy_primer/projects/dd-trace-py/ddtrace/internal/coverage/instrumentation_py3_12.py:57:9 - error: Declaration "current_import_name" is obscured by a declaration of the same name (reportRedeclaration)
+ /tmp/mypy_primer/projects/dd-trace-py/ddtrace/internal/coverage/instrumentation_py3_12.py:57:48 - error: Expression of type "None" is incompatible with declared type "str"
+ "None" is incompatible with "str" (reportAssignmentType)
+ /tmp/mypy_primer/projects/dd-trace-py/ddtrace/internal/coverage/instrumentation_py3_12.py:58:9 - error: Declaration "current_import_package" is obscured by a declaration of the same name (reportRedeclaration)
+ /tmp/mypy_primer/projects/dd-trace-py/ddtrace/internal/coverage/instrumentation_py3_12.py:58:51 - error: Expression of type "None" is incompatible with declared type "str"
+ "None" is incompatible with "str" (reportAssignmentType)
+ /tmp/mypy_primer/projects/dd-trace-py/ddtrace/internal/coverage/instrumentation_py3_12.py:82:32 - error: Argument of type "int" cannot be assigned to parameter "object" of type "bytes" in function "append"
+ "int" is incompatible with "bytes" (reportArgumentType)
+ /tmp/mypy_primer/projects/dd-trace-py/ddtrace/internal/coverage/instrumentation_py3_12.py:87:51 - error: Argument of type "list[bytes | int]" cannot be assigned to parameter "bytes" of type "Iterable[SupportsIndex] | SupportsBytes | ReadableBuffer" in function "from_bytes"
+ "bytes" is incompatible with protocol "SupportsIndex"
+ "__index__" is not present (reportArgumentType)
+ /tmp/mypy_primer/projects/dd-trace-py/ddtrace/internal/coverage/instrumentation_py3_12.py:101:40 - error: Argument of type "Tuple[str, ...] | None" cannot be assigned to parameter "iterable" of type "Iterable[_T@list]" in function "__init__"
+ Type "Tuple[str, ...] | None" is incompatible with type "Iterable[str]"
+ "None" is incompatible with protocol "Iterable[str]"
+ "__iter__" is not present (reportArgumentType)
+ /tmp/mypy_primer/projects/dd-trace-py/ddtrace/internal/coverage/instrumentation_py3_12.py:114:40 - error: Argument of type "Tuple[str, ...] | None" cannot be assigned to parameter "iterable" of type "Iterable[_T@list]" in function "__init__"
+ Type "Tuple[str, ...] | None" is incompatible with type "Iterable[str]"
+ "None" is incompatible with protocol "Iterable[str]"
+ "__iter__" is not present (reportArgumentType)
+ /tmp/mypy_primer/projects/dd-trace-py/ddtrace/internal/coverage/instrumentation_py3_12.py:128:9 - error: Argument of type "tuple[HookType, str, dict[int, Tuple[str, Tuple[str, ...] | None]]]" cannot be assigned to parameter "value" of type "Tuple[HookType, str, Dict[int, Tuple[str, Tuple[str] | None]]]" in function "__setitem__"
+ "tuple[HookType, str, dict[int, Tuple[str, Tuple[str, ...] | None]]]" is incompatible with "Tuple[HookType, str, Dict[int, Tuple[str, Tuple[str] | None]]]"
+ Tuple entry 3 is incorrect type
+ "dict[int, Tuple[str, Tuple[str, ...] | None]]" is incompatible with "Dict[int, Tuple[str, Tuple[str] | None]]"
+ Type parameter "_VT@dict" is invariant, but "Tuple[str, Tuple[str, ...] | None]" is not the same as "Tuple[str, Tuple[str] | None]"
+ Consider switching from "dict" to "Mapping" which is covariant in the value type (reportArgumentType)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/internal/wrapping/context.py:668:16 - error: "i" is possibly unbound (reportPossiblyUnboundVariable)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/internal/wrapping/context.py:668:20 - error: "i" is possibly unbound (reportPossiblyUnboundVariable)
- /tmp/mypy_primer/projects/dd-trace-py/ddtrace/vendor/psutil/setup.py:165:30 - error: Cannot access attribute "set_executable" for class "UnixCCompiler"
- Attribute "set_executable" is unknown (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/dd-trace-py/tests/appsec/iast/aspects/test_ospath_aspects.py:560:11 - error: "ospathsplitroot_aspect" is not defined (reportUndefinedVariable)
- /tmp/mypy_primer/projects/dd-trace-py/tests/appsec/iast/aspects/test_ospath_aspects.py:578:11 - error: "ospathsplitroot_aspect" is not defined (reportUndefinedVariable)
- /tmp/mypy_primer/projects/dd-trace-py/tests/appsec/iast/aspects/test_ospath_aspects.py:598:11 - error: "ospathsplitroot_aspect" is not defined (reportUndefinedVariable)
- /tmp/mypy_primer/projects/dd-trace-py/tests/appsec/iast/aspects/test_ospath_aspects.py:618:11 - error: "ospathsplitroot_aspect" is not defined (reportUndefinedVariable)
- /tmp/mypy_primer/projects/dd-trace-py/tests/appsec/iast/aspects/test_ospath_aspects.py:626:11 - error: "ospathsplitroot_aspect" is not defined (reportUndefinedVariable)
- /tmp/mypy_primer/projects/dd-trace-py/tests/appsec/iast/aspects/test_ospath_aspects.py:635:13 - error: "ospathsplitroot_aspect" is not defined (reportUndefinedVariable)
- /tmp/mypy_primer/projects/dd-trace-py/tests/appsec/iast/aspects/test_ospath_aspects.py:647:11 - error: "ospathsplitroot_aspect" is not defined (reportUndefinedVariable)
- /tmp/mypy_primer/projects/dd-trace-py/tests/appsec/iast/aspects/test_ospath_aspects.py:660:11 - error: "ospathsplitroot_aspect" is not defined (reportUndefinedVariable)
- /tmp/mypy_primer/projects/dd-trace-py/tests/appsec/iast/aspects/test_ospath_aspects.py:674:11 - error: "ospathsplitroot_aspect" is not defined (reportUndefinedVariable)
- /tmp/mypy_primer/projects/dd-trace-py/tests/appsec/iast/aspects/test_ospath_aspects.py:690:11 - error: "ospathsplitdrive_aspect" is not defined (reportUndefinedVariable)
- /tmp/mypy_primer/projects/dd-trace-py/tests/appsec/iast/aspects/test_ospath_aspects.py:707:11 - error: "ospathsplitdrive_aspect" is not defined (reportUndefinedVariable)
+ /tmp/mypy_primer/projects/dd-trace-py/tests/contrib/psycopg/test_psycopg_async.py:87:14 - error: Cannot access attribute "assertEquals" for class "PsycopgCore*"
+ Attribute "assertEquals" is unknown (reportAttributeAccessIssue)
... (truncated 13 lines) ...
koda-validate (https://github.com/keithasaurus/koda-validate)
- /tmp/mypy_primer/projects/koda-validate/tests/test_311_plus.py
- /tmp/mypy_primer/projects/koda-validate/tests/test_311_plus.py:1:20 - error: "NotRequired" is unknown import symbol (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/koda-validate/tests/test_311_plus.py:1:33 - error: "Required" is unknown import symbol (reportAttributeAccessIssue)
- 141 errors, 5 warnings, 0 informations
+ 139 errors, 5 warnings, 0 informations
spack (https://github.com/spack/spack)
+ /tmp/mypy_primer/projects/spack/lib/spack/llnl/util/filesystem.py:1624:13 - error: No overloads for "__call__" match the provided arguments (reportCallIssue)
- /tmp/mypy_primer/projects/spack/lib/spack/llnl/util/filesystem.py:1624:53 - error: Argument of type "bool" cannot be assigned to parameter "onerror" of type "_OnErrorCallback | None" in function "__call__"
+ /tmp/mypy_primer/projects/spack/lib/spack/llnl/util/filesystem.py:1624:53 - error: Argument of type "bool" cannot be assigned to parameter "onexc" of type "_OnExcCallback | None" in function "__call__"
- Type "bool" is incompatible with type "_OnErrorCallback | None"
+ Type "bool" is incompatible with type "_OnExcCallback | None"
- Type "bool" is incompatible with type "_OnErrorCallback"
+ Type "bool" is incompatible with type "_OnExcCallback"
+ /tmp/mypy_primer/projects/spack/lib/spack/llnl/util/filesystem.py:1633:13 - error: No overloads for "__call__" match the provided arguments (reportCallIssue)
- /tmp/mypy_primer/projects/spack/lib/spack/llnl/util/filesystem.py:1633:35 - error: Argument of type "bool" cannot be assigned to parameter "onerror" of type "_OnErrorCallback | None" in function "__call__"
+ /tmp/mypy_primer/projects/spack/lib/spack/llnl/util/filesystem.py:1633:35 - error: Argument of type "bool" cannot be assigned to parameter "onexc" of type "_OnExcCallback | None" in function "__call__"
- Type "bool" is incompatible with type "_OnErrorCallback | None"
+ Type "bool" is incompatible with type "_OnExcCallback | None"
- Type "bool" is incompatible with type "_OnErrorCallback"
+ Type "bool" is incompatible with type "_OnExcCallback"
+ /tmp/mypy_primer/projects/spack/lib/spack/llnl/util/lang.py:796:50 - error: Cannot access attribute "get" for class "EntryPoints"
+ Attribute "get" is unknown (reportAttributeAccessIssue)
+ /tmp/mypy_primer/projects/spack/lib/spack/spack/fetch_strategy.py:853:17 - error: No overloads for "__call__" match the provided arguments (reportCallIssue)
+ /tmp/mypy_primer/projects/spack/lib/spack/spack/operating_systems/windows_os.py:65:23 - error: Argument of type "str" cannot be assigned to parameter "process_group" of type "int | None" in function "check_output"
+ Type "str" is incompatible with type "int | None"
+ "str" is incompatible with "int"
+ "str" is incompatible with "None" (reportArgumentType)
+ /tmp/mypy_primer/projects/spack/lib/spack/spack/test/packaging.py:56:30 - error: Argument of type "Prefix | None" cannot be assigned to parameter "args" of type "StrPath" in function "__init__" (reportArgumentType)
+ /tmp/mypy_primer/projects/spack/var/spack/repos/builtin/packages/trilinos/package.py:911:70 - error: Argument of type "Unknown | Prefix | None" cannot be assigned to parameter "args" of type "StrPath" in function "__init__" (reportArgumentType)
- 22733 errors, 73 warnings, 0 informations
+ 22740 errors, 73 warnings, 0 informations
materialize (https://github.com/MaterializeInc/materialize)
- /tmp/mypy_primer/projects/materialize/ci/cleanup/aws.py:10:22 - error: "UTC" is unknown import symbol (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/materialize/ci/load/periodic.py
- /tmp/mypy_primer/projects/materialize/ci/load/periodic.py:34:43 - error: "UTC" is not a known attribute of module "datetime" (reportAttributeAccessIssue)
+ /tmp/mypy_primer/projects/materialize/misc/dbt-materialize/setup.py
+ /tmp/mypy_primer/projects/materialize/misc/dbt-materialize/setup.py:17:6 - warning: Stub file not found for "distutils.core" (reportMissingTypeStubs)
- /tmp/mypy_primer/projects/materialize/misc/python/materialize/mzexplore/common.py:414:39 - error: Argument of type "str | None" cannot be assigned to parameter "package" of type "Package" in function "files" (reportArgumentType)
- /tmp/mypy_primer/projects/materialize/misc/python/materialize/optbench/__init__.py
- /tmp/mypy_primer/projects/materialize/misc/python/materialize/optbench/__init__.py:18:39 - error: Argument of type "str | None" cannot be assigned to parameter "package" of type "Package" in function "files" (reportArgumentType)
- 13 errors, 347 warnings, 0 informations
+ 9 errors, 348 warnings, 0 informations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8797