Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default python version not being picked up from the environment #9735

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

rchiodo
Copy link
Collaborator

@rchiodo rchiodo commented Jan 21, 2025

Addresses #9702

Root cause was always checking for a pythonPath entry before setting the default version. This is incorrect in situations where a pythonPath is not specified, it should default to the current environment.

The original change that caused this problem was supposed to fix an issue where the default version was being set before the python path, but given that the default version is the last thing to be set, this isn't necessary.

Added a test to make sure this doesn't regress in the future.

This comment has been minimized.

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

more-itertools (https://github.com/more-itertools/more-itertools)
+   /tmp/mypy_primer/projects/more-itertools/more_itertools/recipes.py:987:27 - error: "batched" is unknown import symbol (reportAttributeAccessIssue)
-   /tmp/mypy_primer/projects/more-itertools/more_itertools/recipes.py:993:15 - error: Type "(iterable: Unknown, n: Unknown, *, strict: bool = False) -> Generator[tuple[Unknown, ...], Any, None]" is not assignable to declared type "(iterable: Unknown, n: Unknown, *, strict: bool = False) -> batched[Unknown]"
-     Type "(iterable: Unknown, n: Unknown, *, strict: bool = False) -> Generator[tuple[Unknown, ...], Any, None]" is not assignable to type "(iterable: Unknown, n: Unknown, *, strict: bool = False) -> batched[Unknown]"
-       Function return type "Generator[tuple[Unknown, ...], Any, None]" is incompatible with type "batched[Unknown]"
-         "Generator[tuple[Unknown, ...], Any, None]" is not assignable to "batched[Unknown]" (reportAssignmentType)

starlette (https://github.com/encode/starlette)
+   /tmp/mypy_primer/projects/starlette/starlette/_utils.py:79:35 - error: "BaseExceptionGroup" is possibly unbound (reportPossiblyUnboundVariable)
+   /tmp/mypy_primer/projects/starlette/starlette/_utils.py:79:67 - error: Cannot access attribute "exceptions" for class "BaseException"
+     Attribute "exceptions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/starlette/starlette/_utils.py:80:27 - error: Cannot access attribute "exceptions" for class "BaseException"
+     Attribute "exceptions" is unknown (reportAttributeAccessIssue)
- 79 errors, 3 warnings, 0 informations 
+ 82 errors, 3 warnings, 0 informations 

rich (https://github.com/Textualize/rich)
+ /tmp/mypy_primer/projects/rich/rich/progress.py
+   /tmp/mypy_primer/projects/rich/rich/progress.py:45:10 - warning: Import "typing_extensions" could not be resolved from source (reportMissingModuleSource)
- 364 errors, 41 warnings, 0 informations 
+ 364 errors, 42 warnings, 0 informations 

paasta (https://github.com/yelp/paasta)
+     Type "Awaitable[Sequence[Unknown]]" is not assignable to type "_CoroutineLike[_T@create_task]"
-     "Awaitable[Sequence[Unknown]]" is not assignable to "Coroutine[Any, Any, _T@create_task]" (reportArgumentType)
+       "Awaitable[Sequence[Unknown]]" is not assignable to "Coroutine[Any, Any, _T@create_task]"
+       "Awaitable[Sequence[Unknown]]" is incompatible with protocol "Generator[Any, None, _T@create_task]"
+         "__next__" is not present
+         "send" is not present
+         "throw" is not present
+         "close" is not present
+         "__iter__" is not present (reportArgumentType)
+     Type "Awaitable[Sequence[Unknown]]" is not assignable to type "_CoroutineLike[_T@create_task]"
-     "Awaitable[Sequence[Unknown]]" is not assignable to "Coroutine[Any, Any, _T@create_task]" (reportArgumentType)
+       "Awaitable[Sequence[Unknown]]" is not assignable to "Coroutine[Any, Any, _T@create_task]"
+       "Awaitable[Sequence[Unknown]]" is incompatible with protocol "Generator[Any, None, _T@create_task]"
+         "__next__" is not present
+         "send" is not present
+         "throw" is not present
+         "close" is not present
+         "__iter__" is not present (reportArgumentType)

psycopg (https://github.com/psycopg/psycopg)
+ /tmp/mypy_primer/projects/psycopg/psycopg/psycopg/_compat.py
+   /tmp/mypy_primer/projects/psycopg/psycopg/psycopg/_compat.py:17:10 - warning: Import "typing_extensions" could not be resolved from source (reportMissingModuleSource)
+   /tmp/mypy_primer/projects/psycopg/psycopg/psycopg/_compat.py:22:10 - warning: Import "typing_extensions" could not be resolved from source (reportMissingModuleSource)
- /tmp/mypy_primer/projects/psycopg/psycopg_c/build_backend/psycopg_build_ext.py
+ /tmp/mypy_primer/projects/psycopg/psycopg_c/build_backend/cython_backend.py
-   /tmp/mypy_primer/projects/psycopg/psycopg_c/build_backend/psycopg_build_ext.py:15:23 - error: "log" is unknown import symbol (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/psycopg/psycopg_c/build_backend/cython_backend.py:21:12 - error: Import "tomli" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/psycopg/psycopg_pool/psycopg_pool/_compat.py:19:10 - warning: Import "typing_extensions" could not be resolved from source (reportMissingModuleSource)
+   /tmp/mypy_primer/projects/psycopg/psycopg_pool/psycopg_pool/_compat.py:24:10 - warning: Import "typing_extensions" could not be resolved from source (reportMissingModuleSource)
-   /tmp/mypy_primer/projects/psycopg/tests/test_psycopg_dbapi20.py:45:14 - error: Cannot assign to attribute "failUnless" for class "type[PsycopgTests]"
-     Attribute "failUnless" is unknown (reportAttributeAccessIssue)
-   /tmp/mypy_primer/projects/psycopg/tests/test_psycopg_dbapi20.py:46:17 - error: Cannot assign to attribute "assertEquals" for class "type[PsycopgTPCTests]"
-     Attribute "assertEquals" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/psycopg/tests/utils.py:16:12 - warning: Import "typing_extensions" could not be resolved from source (reportMissingModuleSource)
- 1772 errors, 104 warnings, 0 informations 
+ 1770 errors, 109 warnings, 0 informations 

yarl (https://github.com/aio-libs/yarl)
+   /tmp/mypy_primer/projects/yarl/packaging/pep517_backend/_backend.py:44:22 - error: "chdir_cm" is unknown import symbol (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/yarl/packaging/pep517_backend/_compat.py:28:10 - error: Import "tomllib" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/yarl/packaging/pep517_backend/_cython_configuration.py:12:22 - error: "load_toml_from_string" is unknown import symbol (reportAttributeAccessIssue)
- 240 errors, 11 warnings, 0 informations 
+ 243 errors, 11 warnings, 0 informations 

pytest (https://github.com/pytest-dev/pytest)
+   /tmp/mypy_primer/projects/pytest/src/_pytest/debugging.py:397:25 - error: Argument of type "TracebackType | BaseException" cannot be assigned to parameter "traceback" of type "TracebackType | None" in function "interaction"
+     Type "TracebackType | BaseException" is not assignable to type "TracebackType | None"
+       Type "BaseException" is not assignable to type "TracebackType | None"
+         "BaseException" is not assignable to "TracebackType"
+         "BaseException" is not assignable to "None" (reportArgumentType)
+   /tmp/mypy_primer/projects/pytest/src/_pytest/fixtures.py:76:10 - error: Import "exceptiongroup" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/pytest/src/_pytest/runner.py:40:10 - error: Import "exceptiongroup" could not be resolved (reportMissingImports)
+ /tmp/mypy_primer/projects/pytest/src/_pytest/threadexception.py
+   /tmp/mypy_primer/projects/pytest/src/_pytest/threadexception.py:24:10 - error: Import "exceptiongroup" could not be resolved (reportMissingImports)
+ /tmp/mypy_primer/projects/pytest/src/_pytest/unraisableexception.py
+   /tmp/mypy_primer/projects/pytest/src/_pytest/unraisableexception.py:24:10 - error: Import "exceptiongroup" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/pytest/src/_pytest/_code/code.py:51:10 - error: Import "exceptiongroup" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/pytest/src/_pytest/config/findpaths.py:64:20 - error: Import "tomli" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/pytest/testing/test_runner.py:25:10 - error: Import "exceptiongroup" could not be resolved (reportMissingImports)
-   /tmp/mypy_primer/projects/pytest/testing/test_runner.py:140:32 - error: Cannot access attribute "exceptions" for class "Exception"
-     Attribute "exceptions" is unknown (reportAttributeAccessIssue)
-   /tmp/mypy_primer/projects/pytest/testing/test_runner.py:141:32 - error: Cannot access attribute "exceptions" for class "Exception"
-     Attribute "exceptions" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/pytest/testing/code/test_excinfo.py:34:10 - error: Import "exceptiongroup" could not be resolved (reportMissingImports)
- 693 errors, 44 warnings, 0 informations 
+ 700 errors, 44 warnings, 0 informations 

openlibrary (https://github.com/internetarchive/openlibrary)
+   /tmp/mypy_primer/projects/openlibrary/openlibrary/core/wikidata.py:93:87 - error: Strings nested within an f-string cannot use the same quote character as the f-string prior to Python 3.12 (reportGeneralTypeIssues)
+   /tmp/mypy_primer/projects/openlibrary/openlibrary/plugins/openlibrary/status.py:113:54 - error: "UTC" is not a known attribute of module "datetime" (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/openlibrary/openlibrary/plugins/upstream/table_of_contents.py:4:20 - error: "Required" is unknown import symbol (reportAttributeAccessIssue)
- 1249 errors, 68 warnings, 0 informations 
+ 1252 errors, 68 warnings, 0 informations 

steam.py (https://github.com/Gobot1234/steam.py)
+   /tmp/mypy_primer/projects/steam.py/poetry_build.py:8:12 - error: Import "tomllib" could not be resolved (reportMissingImports)
-   /tmp/mypy_primer/projects/steam.py/poetry_build.py:14:13 - error: Type of "loads" is partially unknown
+   /tmp/mypy_primer/projects/steam.py/poetry_build.py:14:13 - error: Type of "loads" is unknown (reportUnknownMemberType)
-     Type of "loads" is "((s: str, /, *, parse_float: ((str) -> Any) = ...) -> dict[str, Any]) | Unknown" (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/scripts/blacken_docs_correctly.py:20:12 - error: Import "tomllib" could not be resolved (reportMissingImports)
-   /tmp/mypy_primer/projects/steam.py/scripts/blacken_docs_correctly.py:33:21 - error: Type of "load" is partially unknown
+   /tmp/mypy_primer/projects/steam.py/scripts/blacken_docs_correctly.py:33:21 - error: Type of "load" is unknown (reportUnknownMemberType)
-     Type of "load" is "((fp: SupportsRead[bytes], /, *, parse_float: ((str) -> Any) = ...) -> dict[str, Any]) | Unknown" (reportUnknownMemberType)
-   /tmp/mypy_primer/projects/steam.py/scripts/blacken_docs_correctly.py:35:31 - error: Type of "get" is partially unknown
+   /tmp/mypy_primer/projects/steam.py/scripts/blacken_docs_correctly.py:35:31 - error: Type of "get" is unknown (reportUnknownMemberType)
-     Type of "get" is "Overload[(key: str, /) -> (Any | None), (key: str, default: Any, /) -> Any, (key: str, default: _T@get, /) -> (Any | _T@get)] | Unknown" (reportUnknownMemberType)
-   /tmp/mypy_primer/projects/steam.py/scripts/blacken_docs_correctly.py:35:31 - error: Type of "get" is partially unknown
+   /tmp/mypy_primer/projects/steam.py/scripts/blacken_docs_correctly.py:35:31 - error: Type of "get" is unknown (reportUnknownMemberType)
-     Type of "get" is "Any | Unknown" (reportUnknownMemberType)
-     Type of "get" is "Overload[(key: str, /) -> (Any | None), (key: str, default: Any, /) -> Any, (key: str, default: _T@get, /) -> (Any | _T@get)] | Unknown" (reportUnknownMemberType)
+     Type of "get" is "Unknown | Overload[(key: str, /) -> (Any | None), (key: str, default: Any, /) -> Any, (key: str, default: _T@get, /) -> (Any | _T@get)]" (reportUnknownMemberType)
-     Type of "get" is "Overload[(key: str, /) -> (Any | None), (key: str, default: Any, /) -> Any, (key: str, default: _T@get, /) -> (Any | _T@get)] | Unknown" (reportUnknownMemberType)
+     Type of "get" is "Unknown | Overload[(key: str, /) -> (Any | None), (key: str, default: Any, /) -> Any, (key: str, default: _T@get, /) -> (Any | _T@get)]" (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/client.py:39:60 - error: "TaskGroup" is unknown import symbol (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/steam.py/steam/client.py:39:71 - error: "timeout" is unknown import symbol (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/steam.py/steam/client.py:306:16 - error: Type of "_tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/client.py:306:16 - error: Type of "create_task" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/client.py:356:9 - error: Type of "_tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/client.py:358:15 - error: Type of "_tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/client.py:358:15 - error: Type of "__aenter__" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/client.py:365:19 - error: Type of "_tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/client.py:365:19 - error: Type of "__aexit__" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/client.py:451:13 - error: Type of "_tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/client.py:460:57 - error: Type of "_tg" is unknown (reportUnknownMemberType)
-     Type of "replace" is "Unknown | ((old: str, new: str, /, count: SupportsIndex = -1) -> str) | Any" (reportUnknownMemberType)
+     Type of "replace" is "Unknown | ((old: str, new: str, count: SupportsIndex = -1, /) -> str) | Any" (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:28:56 - error: "Self" is unknown import symbol (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:36:86 - error: "timeout" is unknown import symbol (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:296:9 - error: Type of "tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:296:19 - error: Type of "TaskGroup" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:296:27 - error: "TaskGroup" is not a known attribute of module "asyncio" (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:319:15 - error: Return type is unknown (reportUnknownParameterType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:320:15 - error: Type of "tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:320:15 - error: Type of "__aenter__" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:324:15 - error: Type of "tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:324:15 - error: Type of "__aexit__" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:395:19 - error: Type of "Timeout" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:395:27 - error: "Timeout" is not a known attribute of module "asyncio" (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:396:20 - error: Type of "TaskGroup" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:396:28 - error: "TaskGroup" is not a known attribute of module "asyncio" (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:406:13 - error: Type of "create_task" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:408:13 - error: Type of "reschedule" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:425:9 - error: Type of "tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:425:9 - error: Type of "create_task" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:444:22 - error: Type of "tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:445:13 - error: Type of "tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:445:23 - error: Type of "_tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:506:17 - error: Type of "tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:550:33 - error: Type of "tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:550:33 - error: Type of "create_task" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:553:39 - error: Type of "tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:553:39 - error: Type of "create_task" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:750:17 - error: Type of "tg" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/gateway.py:750:17 - error: Type of "create_task" is unknown (reportUnknownMemberType)
+   /tmp/mypy_primer/projects/steam.py/steam/http.py:14:58 - error: "Unpack" is unknown import symbol (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/steam.py/steam/http.py:56:42 - error: Type of parameter "options" is unknown (reportUnknownParameterType)

... (truncated 47 lines) ...

pyodide (https://github.com/pyodide/pyodide)
+ /tmp/mypy_primer/projects/pyodide/src/py/_pyodide/_importhook.py
+   /tmp/mypy_primer/projects/pyodide/src/py/_pyodide/_importhook.py:187:7 - error: Cannot access attribute "add_note" for class "ModuleNotFoundError"
+     Attribute "add_note" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/pyodide/src/py/pyodide/console.py:490:13 - error: "last_exc" is not a known attribute of module "sys" (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/pyodide/src/py/pyodide/console.py:512:13 - error: "last_exc" is not a known attribute of module "sys" (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/pyodide/src/py/pyodide/webloop.py:265:29 - error: Argument of type "_AwaitableLike[Unknown]" cannot be assigned to parameter "x" of type "Awaitable[T@run_sync]" in function "run_sync"
+     Type "_AwaitableLike[Unknown]" is not assignable to type "Awaitable[Unknown]"
+       "Generator[Any, None, Unknown]" is incompatible with protocol "Awaitable[Unknown]"
+         "__await__" is not present (reportArgumentType)
+   /tmp/mypy_primer/projects/pyodide/src/py/pyodide/webloop.py:266:16 - error: No overloads for "ensure_future" match the provided arguments (reportCallIssue)
+   /tmp/mypy_primer/projects/pyodide/src/py/pyodide/webloop.py:266:38 - error: Argument of type "_AwaitableLike[Unknown]" cannot be assigned to parameter "coro_or_future" of type "Awaitable[_T@ensure_future]" in function "ensure_future"
+     Type "_AwaitableLike[Unknown]" is not assignable to type "Awaitable[Unknown]"
+       "Generator[Any, None, Unknown]" is incompatible with protocol "Awaitable[Unknown]"
+         "__await__" is not present (reportArgumentType)
+   /tmp/mypy_primer/projects/pyodide/src/tests/test_static_typing.py:4:29 - error: "assert_type" is unknown import symbol (reportAttributeAccessIssue)
-   /tmp/mypy_primer/projects/pyodide/src/tests/test_static_typing.py:31:21 - error: "assert_type" mismatch: expected "int" but received "Unknown" (reportAssertTypeFailure)
-   /tmp/mypy_primer/projects/pyodide/src/tests/test_static_typing.py:44:25 - error: "assert_type" mismatch: expected "str" but received "Unknown" (reportAssertTypeFailure)
-   /tmp/mypy_primer/projects/pyodide/src/tests/test_static_typing.py:58:21 - error: "assert_type" mismatch: expected "int" but received "Unknown" (reportAssertTypeFailure)
-   /tmp/mypy_primer/projects/pyodide/src/tests/test_static_typing.py:59:21 - error: "assert_type" mismatch: expected "str" but received "Unknown" (reportAssertTypeFailure)
+   /tmp/mypy_primer/projects/pyodide/src/tests/test_typeconversions.py:1968:40 - error: "NotRequired" is unknown import symbol (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/pyodide/pyodide-build/pyodide_build/buildall.py:194:74 - error: "UTC" is not a known attribute of module "datetime" (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/pyodide/pyodide-build/pyodide_build/common.py:12:8 - error: Import "tomllib" could not be resolved (reportMissingImports)
+   /tmp/mypy_primer/projects/pyodide/pyodide-build/pyodide_build/io.py:2:29 - error: "Self" is unknown import symbol (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/pyodide/pyodide-build/pyodide_build/tests/test_buildpkg.py:5:20 - error: "Self" is unknown import symbol (reportAttributeAccessIssue)
- 748 errors, 14 warnings, 0 informations 
+ 756 errors, 14 warnings, 0 informations 

ibis (https://github.com/ibis-project/ibis)
-   /tmp/mypy_primer/projects/ibis/ibis/backends/snowflake/tests/test_udf.py:110:27 - error: Argument of type "Any | None" cannot be assigned to parameter "args" of type "StrPath" in function "__init__"
-     Type "Any | None" is not assignable to type "StrPath"
-       Type "None" is not assignable to type "StrPath"
-         "None" is not assignable to "str"
-         "None" is incompatible with protocol "PathLike[str]"
-           "__fspath__" is not present (reportArgumentType)
+   /tmp/mypy_primer/projects/ibis/ibis/backends/sql/compilers/bigquery/udf/core.py:494:25 - error: No overloads for "__init__" match the provided arguments
+     Argument types: (list[arg], None, list[Unknown], list[Unknown], None, list[Unknown]) (reportCallIssue)
-     Type "str | None" is not assignable to type "StrPath"
-       Type "None" is not assignable to type "StrPath"
-         "None" is not assignable to "str"
-         "None" is incompatible with protocol "PathLike[str]"
-           "__fspath__" is not present (reportArgumentType)
-   /tmp/mypy_primer/projects/ibis/ibis/backends/tests/base.py:110:21 - error: Argument of type "str | None" cannot be assigned to parameter "args" of type "StrPath" in function "__init__"
- 7441 errors, 120 warnings, 0 informations 
+ 7440 errors, 120 warnings, 0 informations 

sympy (https://github.com/sympy/sympy)
-   /tmp/mypy_primer/projects/sympy/sympy/core/singleton.py:194:28 - error: Cannot assign to attribute "__getstate__" for class "Singleton*"
-     Type "(obj: Unknown) -> None" is not assignable to type "() -> object"
-       Extra parameter "obj" (reportAttributeAccessIssue)
-   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_matchpy_connector.py:120:18 - error: Argument of type "Equality | Unknown" cannot be assigned to parameter "expr" of type "Expr" in function "add"
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_matchpy_connector.py:120:18 - error: Argument of type "Equality | Unknown | Relational | Unequality | Integer" cannot be assigned to parameter "expr" of type "Expr" in function "add"
-     Type "Equality | Unknown" is not assignable to type "Expr"
+     Type "Equality | Unknown | Relational | Unequality | Integer" is not assignable to type "Expr"
-       "Equality" is not assignable to "Expr" (reportArgumentType)
+       "Relational" is not assignable to "Expr" (reportArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_matchpy_connector.py:123:18 - error: Argument of type "Equality | Unknown" cannot be assigned to parameter "expr" of type "Expr" in function "add"
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_matchpy_connector.py:123:18 - error: Argument of type "Equality | Unknown | Relational | Unequality | Integer" cannot be assigned to parameter "expr" of type "Expr" in function "add"
-     Type "Equality | Unknown" is not assignable to type "Expr"
+     Type "Equality | Unknown | Relational | Unequality | Integer" is not assignable to type "Expr"
-       "Equality" is not assignable to "Expr" (reportArgumentType)
+       "Relational" is not assignable to "Expr" (reportArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_matchpy_connector.py:126:9 - error: Argument of type "Equality | Unknown" cannot be assigned to parameter "expr" of type "Expr" in function "add"
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_matchpy_connector.py:126:9 - error: Argument of type "Equality | Unknown | Relational | Unequality | Integer" cannot be assigned to parameter "expr" of type "Expr" in function "add"
-     Type "Equality | Unknown" is not assignable to type "Expr"
+     Type "Equality | Unknown | Relational | Unequality | Integer" is not assignable to type "Expr"
-       "Equality" is not assignable to "Expr" (reportArgumentType)
+       "Relational" is not assignable to "Expr" (reportArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_matchpy_connector.py:132:9 - error: Argument of type "Equality | Unknown" cannot be assigned to parameter "expr" of type "Expr" in function "add"
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_matchpy_connector.py:132:9 - error: Argument of type "Equality | Unknown | Relational | Unequality | Integer" cannot be assigned to parameter "expr" of type "Expr" in function "add"
-     Type "Equality | Unknown" is not assignable to type "Expr"
+     Type "Equality | Unknown | Relational | Unequality | Integer" is not assignable to type "Expr"
-       "Equality" is not assignable to "Expr" (reportArgumentType)
+       "Relational" is not assignable to "Expr" (reportArgumentType)
-   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:895:12 - error: Operator "/" not supported for types "Equality | Unknown" and "Literal[2]"
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:895:12 - error: Operator "/" not supported for types "Equality | Unknown | Relational | Unequality | Integer" and "Literal[2]"
+     Operator "/" not supported for types "Equality" and "Literal[2]"
+     Operator "/" not supported for types "Relational" and "Literal[2]"
-     Operator "/" not supported for types "Equality" and "Literal[2]" (reportOperatorIssue)
+     Operator "/" not supported for types "Unequality" and "Literal[2]" (reportOperatorIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:1863:12 - error: Cannot access attribute "combsimp" for class "Relational"
+     Attribute "combsimp" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:1863:12 - error: Cannot access attribute "combsimp" for class "Unequality"
+     Attribute "combsimp" is unknown (reportAttributeAccessIssue)
+     Attribute "factor" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:1911:14 - error: Cannot access attribute "factor" for class "Relational"
+     Attribute "factor" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:1911:14 - error: Cannot access attribute "factor" for class "Unequality"
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:1918:14 - error: Cannot access attribute "combsimp" for class "Relational"
+     Attribute "combsimp" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:1918:14 - error: Cannot access attribute "combsimp" for class "Unequality"
+     Attribute "combsimp" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:1932:12 - error: Cannot access attribute "combsimp" for class "Relational"
+     Attribute "combsimp" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:1932:12 - error: Cannot access attribute "combsimp" for class "Unequality"
+     Attribute "combsimp" is unknown (reportAttributeAccessIssue)
-   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:1992:22 - error: Argument of type "Equality | Unknown | NaN | Sum" cannot be assigned to parameter "x" of type "ConvertibleToFloat" in function "__new__"
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:1992:22 - error: Argument of type "Equality | Unknown | Relational | Unequality | Integer | NaN | Sum" cannot be assigned to parameter "x" of type "ConvertibleToFloat" in function "__new__"
-     Type "Equality | Unknown | NaN | Sum" is not assignable to type "ConvertibleToFloat"
+     Type "Equality | Unknown | Relational | Unequality | Integer | NaN | Sum" is not assignable to type "ConvertibleToFloat"
-       Type "Equality" is not assignable to type "ConvertibleToFloat"
+       Type "Relational" is not assignable to type "ConvertibleToFloat"
-         "Equality" is not assignable to "str"
+         "Relational" is not assignable to "str"
-         "Equality" is incompatible with protocol "Buffer"
+         "Relational" is incompatible with protocol "Buffer"
-         "Equality" is incompatible with protocol "SupportsFloat"
+         "Relational" is incompatible with protocol "SupportsFloat"
-         "Equality" is incompatible with protocol "SupportsIndex"
+         "Relational" is incompatible with protocol "SupportsIndex"
+     Attribute "gammasimp" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:2074:56 - error: Cannot access attribute "gammasimp" for class "Relational"
+     Attribute "gammasimp" is unknown (reportAttributeAccessIssue)
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:2074:56 - error: Cannot access attribute "gammasimp" for class "Unequality"
-   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:2973:37 - error: Operator "*" not supported for types "Literal[2]" and "Equality | Unknown | NaN | Sum"
+   /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:2973:37 - error: Operator "*" not supported for types "Literal[2]" and "Equality | Unknown | Relational | Unequality | Integer | NaN | Sum"

... (truncated 1294 lines) ...```

Copy link
Collaborator

@erictraut erictraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rchiodo rchiodo merged commit ce4e143 into microsoft:main Jan 22, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants