This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Handle named tuples #339
Merged
Handle named tuples #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
October 23, 2018 19:40
MikhailArkhipov
commented
Nov 2, 2018
src/Analysis/Engine/Impl/Interpreter/Ast/AstAnalysisFunctionWalkerSet.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| [TestMethod, Priority(0)] | ||
| public async Task AstForwardRefFunction2() { |
There was a problem hiding this comment.
Can be a parameterized test.
| => klass.Contains(ProjectState.ClassInfos[BuiltinTypeId.Function]) || klass.Contains(ProjectState.ClassInfos[BuiltinTypeId.BuiltinFunction]); | ||
|
|
||
| public override IAnalysisSet Call(Node node, AnalysisUnit unit, IAnalysisSet[] args, NameExpression[] keywordArgNames) { | ||
| var returnTypes = GetFunctionOverloads().Where(o => o.ReturnType != null).SelectMany(o => o.ReturnType); |
There was a problem hiding this comment.
Do we need .Distinct() here?
src/Analysis/Engine/Impl/Interpreter/Ast/AstTypeAnnotationConverter.cs
Outdated
Show resolved
Hide resolved
src/Analysis/Engine/Impl/Interpreter/Ast/AstTypeAnnotationConverter.cs
Outdated
Show resolved
Hide resolved
Use builtin types from interpreter
| @@ -140,8 +135,7 @@ public static class AnalysisValueSetExtensions { | |||
| /// Performs a delete index operation propagating the index types into | |||
| /// the provided object. | |||
| /// </summary> | |||
| public static void DeleteIndex(this IAnalysisSet self, Node node, AnalysisUnit unit, IAnalysisSet index) { | |||
| } | |||
| public static void DeleteIndex(this IAnalysisSet self, Node node, AnalysisUnit unit, IAnalysisSet index) { } | |||
There was a problem hiding this comment.
Apparently it is called from DDG... Let's leave this alone until we decide fate of the DDG.
AlexanderSher
approved these changes
Nov 5, 2018
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
Handle named tuples
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Type[T]fromtypingtotypeinfoand the AST analysisnamedtuplefromcollectionsvia typeshed annotationsImplement wrapper over tuple so we can expose declared members in completion - separate item in #343